[jira] [Comment Edited] (HBASE-17922) TestRegionServerHostname always fails against hadoop 3.0.0-alpha2

["Appy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077541#comment-16077541 ] 

Appy edited comment on HBASE-17922 at 7/7/17 4:08 AM:
------------------------------------------------------

bq. It looks like something during the aborted startup in MiniHBaseCluster is poisoning the future runs. I wasn't able to figure out exactly what it is, but we can run the test against the HRegionServer directly instead and get the same coverage without breaking other tests in the class. Unless the point was to test the TEST_UTIL, which I don't think it is.

The point is definitely not to test TestUtil, but then, TestUtil.startMiniCluster() runs a lot more non-test code than just {{new HRegionServer()}}. So replacing two is not same.
Howerver, if you are saying we don't really need miniCluster to test this functionality since the config being changed in test (hbase.regionserver.hostname) is limited to HRegionServer, then i buy it.

+1


was (Author: appy):
bq. It looks like something during the aborted startup in MiniHBaseCluster is poisoning the future runs. I wasn't able to figure out exactly what it is, but we can run the test against the HRegionServer directly instead and get the same coverage without breaking other tests in the class. Unless the point was to test the TEST_UTIL, which I don't think it is.

The point is definitely not to test TestUtil, but then, TestUtil.startMiniCluster() runs a lot more non-test code than just {{new HRegionServer()}}. So replacing two is not same.
Howerver, if you are saying we don't really need miniCluster to test this functionality since the config being changed in test (hbase.regionserver.hostname) is limited to HRegionServer, then i buy it.

 1

> TestRegionServerHostname always fails against hadoop 3.0.0-alpha2
> -----------------------------------------------------------------
>
>                 Key: HBASE-17922
>                 URL: https://issues.apache.org/jira/browse/HBASE-17922
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hadoop3
>    Affects Versions: 2.0.0
>            Reporter: Jonathan Hsieh
>            Assignee: Mike Drob
>             Fix For: 2.0.0-alpha-2
>
>         Attachments: HBASE-17922.patch
>
>
> {code}
> Running org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 126.363 sec <<< FAILURE! - in org.apache.hadoop.hbase.regionserver.TestRegionServerHostname
> testRegionServerHostname(org.apache.hadoop.hbase.regionserver.TestRegionServerHostname)  Time elapsed: 120.029 sec  <<< ERROR!
> org.junit.runners.model.TestTimedOutException: test timed out after 120000 milliseconds
> 	at java.lang.Thread.sleep(Native Method)
> 	at org.apache.hadoop.hbase.util.JVMClusterUtil.startup(JVMClusterUtil.java:221)
> 	at org.apache.hadoop.hbase.LocalHBaseCluster.startup(LocalHBaseCluster.java:405)
> 	at org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:225)
> 	at org.apache.hadoop.hbase.MiniHBaseCluster.<init>(MiniHBaseCluster.java:94)
> 	at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:1123)
> 	at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1077)
> 	at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:948)
> 	at org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:942)
> 	at org.apache.hadoop.hbase.regionserver.TestRegionServerHostname.testRegionServerHostname(TestRegionServerHostname.java:88)
> Results :
> Tests in error: 
>   TestRegionServerHostname.testRegionServerHostname:88 » TestTimedOut test timed...
> Tests run: 2, Failures: 0, Errors: 1, Skipped: 0
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)