[jira] [Comment Edited] (YETUS-1075) maven unit test text says pass with a -1 vote

["Allen Wittenauer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229530#comment-17229530 ] 

Allen Wittenauer edited comment on YETUS-1075 at 11/10/20, 9:25 PM:
--------------------------------------------------------------------

A trace of the issue:

maven exits with success, even though unit tests failed:

https://github.com/apache/yetus/blob/d65f34e44a9a758bf2de52d3139acfaae679c8b1/precommit/src/main/shell/test-patch.sh#L1964

Test output processor correctly determines that unit tests failed, sets the vote to -1 but doesn't reset the message since it is assumed that the previous module_status set something sane:

https://github.com/apache/yetus/blob/d65f34e44a9a758bf2de52d3139acfaae679c8b1/precommit/src/main/shell/test-patch.sh#L2137

actually changing value:

https://github.com/apache/yetus/blob/d65f34e44a9a758bf2de52d3139acfaae679c8b1/precommit/src/main/shell/test-patch.sh#L2150


This feels more like maven's bug than ours.


was (Author: aw):
maven is returning 0 even on test failure.

> maven unit test text says pass with a -1 vote
> ---------------------------------------------
>
>                 Key: YETUS-1075
>                 URL: https://issues.apache.org/jira/browse/YETUS-1075
>             Project: Yetus
>          Issue Type: Bug
>          Components: Precommit
>    Affects Versions: 0.13.0
>            Reporter: Allen Wittenauer
>            Priority: Minor
>              Labels: beginner
>             Fix For: 0.14.0
>
>
> | {color:red}-1{color} | {color:red} unit {color} | {color:red}  9m 42s{color} | [/patch-unit-hadoop-common-project_hadoop-common.txt|https://ci-hadoop.apache.org/job/PreCommit-HDFS-Build/295/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt] | {color:red} hadoop-common in the patch passed. {color} |
> Text is clearly not correct but vote is.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)