You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/03 14:34:20 UTC

[GitHub] [kafka] yashmayya commented on a diff in pull request #12355: KAFKA-14017: Implement new KIP-618 APIs in FileStreamSourceConnector

yashmayya commented on code in PR #12355:
URL: https://github.com/apache/kafka/pull/12355#discussion_r962159990


##########
connect/file/src/main/java/org/apache/kafka/connect/file/FileStreamSourceConnector.java:
##########
@@ -95,4 +96,18 @@ public void stop() {
     public ConfigDef config() {
         return CONFIG_DEF;
     }
+
+    @Override
+    public ExactlyOnceSupport exactlyOnceSupport(Map<String, String> props) {

Review Comment:
   Should we also document this in the [Connector Development Guide](https://kafka.apache.org/documentation/#connect_development) (along with the other new `SourceConnector::canDefineTransactionBoundaries` method)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org