You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/08/30 07:06:40 UTC

[GitHub] [cordova-electron] erisu opened a new pull request #202: feat!: remove old VERSION file

erisu opened a new pull request #202:
URL: https://github.com/apache/cordova-electron/pull/202


   ### Motivation, Context & Description
   
   Remove unused VERSION file.
   
   ### Testing
   
   - `npm t`
   - Cordova CLI 10.x
     - `cordova platform add`
     - `cordova platform`
     - `cordova info`
     - `cordova requirements`
     - `cordova build`
     - `cordova run`
   - Cordova CLI 9.x
     - `cordova platform add`
     - `cordova platform`
     - `cordova info`
     - `cordova requirements`
     - `cordova build`
     - `cordova run`
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-electron] codecov-commenter commented on pull request #202: feat!: remove old VERSION file

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #202:
URL: https://github.com/apache/cordova-electron/pull/202#issuecomment-908095981


   # [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#202](https://codecov.io/gh/apache/cordova-electron/pull/202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4cf5957) into [master](https://codecov.io/gh/apache/cordova-electron/commit/f80e1dbd52ba060d52265248bc78a7c7000cdd4c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f80e1db) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-electron/pull/202/graphs/tree.svg?width=650&height=150&src=pr&token=gnoel3CVuB&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/cordova-electron/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##            master      #202   +/-   ##
   =========================================
     Coverage   100.00%   100.00%           
   =========================================
     Files           14        14           
     Lines          653       653           
   =========================================
     Hits           653       653           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-electron/pull/202?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/202?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f80e1db...4cf5957](https://codecov.io/gh/apache/cordova-electron/pull/202?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-electron] erisu merged pull request #202: feat!: remove old VERSION file

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #202:
URL: https://github.com/apache/cordova-electron/pull/202


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org