You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2015/02/17 22:15:32 UTC
Review Request 31135: Pin protobuf dependency to 2.6.1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31135/
-----------------------------------------------------------
Review request for Aurora, Joe Smith and Kevin Sweeney.
Bugs: AURORA-1128
https://issues.apache.org/jira/browse/AURORA-1128
Repository: aurora
Description
-------
Pin protobuf dependency to 2.6.1
Diffs
-----
3rdparty/python/requirements.txt PRE-CREATION
src/main/python/apache/aurora/executor/BUILD 1ad8f82cdce85cf228c53e088171918e36ed536d
src/main/python/apache/aurora/executor/bin/BUILD aeb8aee6f50a0d89714626e933699c0a13b363d9
src/main/python/apache/aurora/executor/common/BUILD 335ebc4809096c5f128846cd846d33910a777968
Diff: https://reviews.apache.org/r/31135/diff/
Testing
-------
$ ./pants binary src/main/python/apache/aurora/executor/bin:thermos_executor && ./pants binary src/main/python/apache/aurora/executor/bin:gc_executor
$ unzip gc_executor.pex -d gc_executor
$ unzip thermos_executor.pex -d thermos_executor
$ ls gc_executor/.deps/ | grep protobuf
protobuf-2.6.1-py2.7.egg
$ ls thermos_executor/.deps/ | grep protobuf
protobuf-2.6.1-py2.7.egg
$ ./pants test.pytest --no-fast src/test/python::
Thanks,
Zameer Manji
Re: Review Request 31135: Pin protobuf dependency to 2.6.1
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31135/#review72792
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Feb. 17, 2015, 1:15 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31135/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 1:15 p.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: AURORA-1128
> https://issues.apache.org/jira/browse/AURORA-1128
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Pin protobuf dependency to 2.6.1
>
>
> Diffs
> -----
>
> 3rdparty/python/requirements.txt PRE-CREATION
> src/main/python/apache/aurora/executor/BUILD 1ad8f82cdce85cf228c53e088171918e36ed536d
> src/main/python/apache/aurora/executor/bin/BUILD aeb8aee6f50a0d89714626e933699c0a13b363d9
> src/main/python/apache/aurora/executor/common/BUILD 335ebc4809096c5f128846cd846d33910a777968
>
> Diff: https://reviews.apache.org/r/31135/diff/
>
>
> Testing
> -------
>
> $ ./pants binary src/main/python/apache/aurora/executor/bin:thermos_executor && ./pants binary src/main/python/apache/aurora/executor/bin:gc_executor
> $ unzip gc_executor.pex -d gc_executor
> $ unzip thermos_executor.pex -d thermos_executor
> $ ls gc_executor/.deps/ | grep protobuf
> protobuf-2.6.1-py2.7.egg
> $ ls thermos_executor/.deps/ | grep protobuf
> protobuf-2.6.1-py2.7.egg
> $ ./pants test.pytest --no-fast src/test/python::
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 31135: Pin protobuf dependency to 2.6.1
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31135/#review72799
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Feb. 17, 2015, 1:15 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31135/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 1:15 p.m.)
>
>
> Review request for Aurora, Joe Smith and Kevin Sweeney.
>
>
> Bugs: AURORA-1128
> https://issues.apache.org/jira/browse/AURORA-1128
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Pin protobuf dependency to 2.6.1
>
>
> Diffs
> -----
>
> 3rdparty/python/requirements.txt PRE-CREATION
> src/main/python/apache/aurora/executor/BUILD 1ad8f82cdce85cf228c53e088171918e36ed536d
> src/main/python/apache/aurora/executor/bin/BUILD aeb8aee6f50a0d89714626e933699c0a13b363d9
> src/main/python/apache/aurora/executor/common/BUILD 335ebc4809096c5f128846cd846d33910a777968
>
> Diff: https://reviews.apache.org/r/31135/diff/
>
>
> Testing
> -------
>
> $ ./pants binary src/main/python/apache/aurora/executor/bin:thermos_executor && ./pants binary src/main/python/apache/aurora/executor/bin:gc_executor
> $ unzip gc_executor.pex -d gc_executor
> $ unzip thermos_executor.pex -d thermos_executor
> $ ls gc_executor/.deps/ | grep protobuf
> protobuf-2.6.1-py2.7.egg
> $ ls thermos_executor/.deps/ | grep protobuf
> protobuf-2.6.1-py2.7.egg
> $ ./pants test.pytest --no-fast src/test/python::
>
>
> Thanks,
>
> Zameer Manji
>
>