You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gora.apache.org by cloudysunny14 <gi...@git.apache.org> on 2017/02/16 14:35:02 UTC

[GitHub] gora pull request #96: Fixed issue GORA-472

GitHub user cloudysunny14 opened a pull request:

    https://github.com/apache/gora/pull/96

    Fixed issue GORA-472

    Couldn't be deleted the column with addColumn because addColumn is Delete the specified version of the specified column.
    I think this will be a solution to GORA-472.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudysunny14/gora GORA-472

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #96
    
----
commit 76c86b960ea4e4d40e49b9c48fe865ca8e826e8e
Author: Kiyonari Harigae <la...@cloudysunny14.org>
Date:   2017-02-16T14:28:32Z

    Fixed issue GORA-472

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #96: Fixed issue GORA-472

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/gora/pull/96


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #96: Fixed issue GORA-472

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/96
  
    @cloudysunny14 yes please if you are not happy with the PR then please close it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #96: Fixed issue GORA-472

Posted by cloudysunny14 <gi...@git.apache.org>.
Github user cloudysunny14 commented on the issue:

    https://github.com/apache/gora/pull/96
  
    I'm sorry for reopen this PR.
    
    I think that the cause of TestHBaseStore#testDeleteByQuery failure is the Delete#addColumn(byte[] family, byte[] qualifier) this delete the latest version of the specified column.
    
    Examples are as follows:
    
    * Delete#addColumn(byte[] family, byte[] qualifier)
    
    Put
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434288/Put/vlen=35/seqid=4
    Put
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434377/Put/vlen=35/seqid=6
    DELETE via Delete#addColumn (It does a get to find the latest versions timestamp and delete latest version of value)
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434377/Delete/vlen=0/seqid=7
    GET
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434288/Put/vlen=35/seqid=0
    
    
    * Delete#addColumns(byte[] family, byte[] qualifier)
    
    PUT
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487827571413/Put/vlen=35/seqid=4
    PUT
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487827571460/Put/vlen=35/seqid=6
    DELETE via Delete#addColumns (It deletes all versions of the specified column)
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487827571506/DeleteColumn/vlen=0/seqid=7
    GET
    no result(puts are invisible)
    
    I thinks that the TestHBaseStore#testDeleteByQuery intends the latter.
    
    Please try TestHBaseStore after merge https://github.com/apache/gora/pull/95
    
    Kiyonari Harigae


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #96: Fixed issue GORA-472

Posted by cloudysunny14 <gi...@git.apache.org>.
Github user cloudysunny14 closed the pull request at:

    https://github.com/apache/gora/pull/96


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #96: Fixed issue GORA-472

Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/96
  
    Hi @cloudysunny14 OK great work. The only test failing is now ```TestHBaseStore#testDeleteByQuery``` which is a big step forward. I must note however that the tests seemed to take a very long time. We can deal with this later on I suppose.
    
    Are you suggesting that the PR associated with this issue fixes TestHBaseStore#testDeleteByQuery ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #96: Fixed issue GORA-472

Posted by cloudysunny14 <gi...@git.apache.org>.
Github user cloudysunny14 commented on the issue:

    https://github.com/apache/gora/pull/96
  
    I'm sorry. This required more investigation.
    Can I close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #96: Fixed issue GORA-472

Posted by cloudysunny14 <gi...@git.apache.org>.
GitHub user cloudysunny14 reopened a pull request:

    https://github.com/apache/gora/pull/96

    Fixed issue GORA-472

    Couldn't be deleted the column with addColumn because addColumn is Delete the specified version of the specified column.
    I think this will be a solution to GORA-472.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudysunny14/gora GORA-472

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #96
    
----
commit 76c86b960ea4e4d40e49b9c48fe865ca8e826e8e
Author: Kiyonari Harigae <la...@cloudysunny14.org>
Date:   2017-02-16T14:28:32Z

    Fixed issue GORA-472

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---