[GitHub] [incubator-doris] imay commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2364: add a control framework between FE and BE through heartbeat #2247
URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r353043690
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/qe/GlobalVariable.java
 ##########
 @@ -56,6 +56,11 @@
     @VariableMgr.VarAttr(name = "query_cache_size")
     private static long queryCacheSize = 1048576;
 
+    public static final String HEARTBEAT_FLAGS = "heartbeat_flags";
+    // the flags passed to Backends
+    @VariableMgr.VarAttr(name = "heartbeat_flags")
+    public static long heartbeatFlags = 0;
 
 Review comment:
   I don't think it is a good idea to set this in one global variables. Maybe each single function has a corresponding variable. 
   Because if there are some flags and you want to change one of them, then you should select all of them and change the result and set it back. This is error prone and not easy to use.
   And may be some flag in the future can't be changed through variables.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org