You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/02/21 18:34:37 UTC
[GitHub] [cloudstack] GabrielBrascher opened a new pull request #6019: Use default timeout and retransmission values for the NFS mount.
GabrielBrascher opened a new pull request #6019:
URL: https://github.com/apache/cloudstack/pull/6019
### Description
When an NFS primary storage pool is created, Libvirt mounts the pool with the default NFS configurations (that can be customized by ADMINS via `/etc/nfsmount.conf`)
This would be a typical mounted NFS pool:
```
~# mount -v | grep <pool_path>
<pool_addr>:/<pool_path> on /mnt/a58cd909-77b7-3c48-b355-f9aeddf1a215 type nfs4 (rw,nosuid,nodev,noexec,relatime,vers=4.2,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=<clientAddress>,local_lock=none,addr=<pool_addr>)
```
However, in case the pool is mounted (for whatever reason) `kvmheartbeat.sh` remounts with `timeo=133` and `retrans=10`:
```
~# mount -v | grep <pool_path>
<pool_addr>:/<pool_path> on /mnt/a58cd909-77b7-3c48-b355-f9aeddf1a215 type nfs4 (rw,relatime,sync,vers=4.2,rsize=1048576,wsize=1048576,namlen=255,acregmin=0,acregmax=0,acdirmin=0,acdirmax=0,soft,noac,proto=tcp,timeo=133,retrans=10,sec=sys,clientaddr=<clientAddress>,local_lock=none,a
ddr=<pool_addr>)
```
This PR aims at removing the hard-coded values to make sure that `kvmheartbeat.sh` "re-mounts" the partitions accordingly to the expected parameters.
Note that if one wants to have a different timeout than the default of 600, it would be possible to achieve it by setting config: `/etc/nfsmount.conf `
```
[ NFSMount_Global_Options ]
timeo=1800
```
With this PR, then it would work fine either with the Libvirt mount and `kvmheartbeat.sh` "re-mount".
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
1. umount primary storage
2. wait for `kvmheartbeat.sh` to mount it back
3. check that there is no longer the hardcoded parameters and the pool NFS timeout and retransmission values respect the default value (or the one set by ADMINs)
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6019: Use default timeout and retransmission values for the NFS mount.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6019:
URL: https://github.com/apache/cloudstack/pull/6019#issuecomment-1047732108
<b>Trillian test result (tid-3406)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33946 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6019-t3406-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 310.50 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6019: Use default timeout and retransmission values for the NFS mount.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6019:
URL: https://github.com/apache/cloudstack/pull/6019#issuecomment-1047146266
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6019: Use default timeout and retransmission values for the NFS mount.
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6019:
URL: https://github.com/apache/cloudstack/pull/6019#issuecomment-1047342474
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6019: Use default timeout and retransmission values for the NFS mount.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6019:
URL: https://github.com/apache/cloudstack/pull/6019#issuecomment-1047363383
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6019: Use default timeout and retransmission values for the NFS mount.
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6019:
URL: https://github.com/apache/cloudstack/pull/6019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6019: Use default timeout and retransmission values for the NFS mount.
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6019:
URL: https://github.com/apache/cloudstack/pull/6019#issuecomment-1047166074
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6019: Use default timeout and retransmission values for the NFS mount.
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6019:
URL: https://github.com/apache/cloudstack/pull/6019#issuecomment-1047146058
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org