You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by bh...@apache.org on 2015/03/09 09:56:45 UTC

git commit: updated refs/heads/master to 8591383

Repository: cloudstack
Updated Branches:
  refs/heads/master 5256b0205 -> 8591383bc


CLOUDSTACK-8307: UI not showing all Domains, if there are more than 24 domains then the last domain gets cut off on firefox and IE. Added a flag in treeview widget and based on the flag adding css class which will make overflow as scroll instead of the default auto.

Fixes #101

Signed-off-by: Rohit Yadav <ro...@shapeblue.com>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/8591383b
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/8591383b
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/8591383b

Branch: refs/heads/master
Commit: 8591383bcc09b4fd0ff1c6336c6c45199be250b3
Parents: 5256b02
Author: ramamurtis <ra...@citrix.com>
Authored: Mon Mar 9 14:15:29 2015 +0530
Committer: Rohit Yadav <ro...@shapeblue.com>
Committed: Mon Mar 9 14:26:29 2015 +0530

----------------------------------------------------------------------
 ui/css/cloudstack3.css            | 4 ++++
 ui/scripts/domains.js             | 1 +
 ui/scripts/ui/widgets/treeView.js | 4 ++++
 3 files changed, 9 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/8591383b/ui/css/cloudstack3.css
----------------------------------------------------------------------
diff --git a/ui/css/cloudstack3.css b/ui/css/cloudstack3.css
index 54facdf..887364a 100644
--- a/ui/css/cloudstack3.css
+++ b/ui/css/cloudstack3.css
@@ -7888,6 +7888,10 @@ label.error {
   overflow: auto;
 }
 
+.tree-view.overflowScroll {
+  overflow: scroll;
+}
+
 #browser .tree-view div.toolbar {
 }
 

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/8591383b/ui/scripts/domains.js
----------------------------------------------------------------------
diff --git a/ui/scripts/domains.js b/ui/scripts/domains.js
index a3cc8c0..e46f104 100644
--- a/ui/scripts/domains.js
+++ b/ui/scripts/domains.js
@@ -21,6 +21,7 @@
 
         // Domain tree
         treeView: {
+		overflowScroll: true,
             // Details
             detailView: {
                 name: 'Domain details',

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/8591383b/ui/scripts/ui/widgets/treeView.js
----------------------------------------------------------------------
diff --git a/ui/scripts/ui/widgets/treeView.js b/ui/scripts/ui/widgets/treeView.js
index 2681945..c948e10 100644
--- a/ui/scripts/ui/widgets/treeView.js
+++ b/ui/scripts/ui/widgets/treeView.js
@@ -83,6 +83,10 @@
         var treeViewArgs = args.treeView;
         var $browser = args.$browser;
 
+        if(treeViewArgs.overflowScroll) {
+            $treeView.addClass('overflowScroll');
+        }
+
         makeTreeList({
             $treeView: $treeView,
             parent: null,