You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/12 19:31:20 UTC
[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #773: Fix
suspect DEBUGASSERT() like PR765
hartmannathan opened a new pull request #773: Fix suspect DEBUGASSERT() like PR765
URL: https://github.com/apache/incubator-nuttx/pull/773
As pointed out by Şükrü Bahadır Arslan in PR765, function calls
inside DEBUGASSERT() will not be executed if DEBUGASSERT is
disabled. Following that PR, I searched for other instances of
similar errors and found four. As there are many thousands of
DEBUGASSERT in the code, this is *not* an exhaustive fix.
arch/arm/src/tms570/tms570_boot.c:
* In function arm_boot(), call tms570_memtest_complete()
outside of the DEBUGASSERT(). Otherwise, if DEBUGASSERT is
disabled, we will never rendezvous with completion of the
test. (Two instances of this fix.)
arch/arm/src/tms570/tms570_clockconfig.c:
* In function tms570_clockconfig(), call
tms570_efc_selftest_complete() outside of the DEBUGASSERT()
for the same reason as above.
boards/arm/sam34/sam4s-xplained-pro/src/sam_boot.c:
* In function board_late_initialize(), call
sam_watchdog_initialize() outside of the DEBUGASSERT() for
the same reason as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #773: Fix suspect
DEBUGASSERT() like PR765
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #773: Fix suspect DEBUGASSERT() like PR765
URL: https://github.com/apache/incubator-nuttx/pull/773
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #773: Fix suspect
DEBUGASSERT() like PR765
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #773: Fix suspect DEBUGASSERT() like PR765
URL: https://github.com/apache/incubator-nuttx/pull/773#issuecomment-612665081
@hartmannathan You will need to fix the nxstyle complaints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #773: Fix suspect
DEBUGASSERT() like PR765
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #773: Fix suspect DEBUGASSERT() like PR765
URL: https://github.com/apache/incubator-nuttx/pull/773#issuecomment-612665387
@hartmannathan these are also appropriate fixes to bring into the 9.0 release, I would think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #773: Fix suspect
DEBUGASSERT() like PR765
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #773: Fix suspect DEBUGASSERT() like PR765
URL: https://github.com/apache/incubator-nuttx/pull/773#issuecomment-612681424
> One of them was a non-static function that does not appear to be called from anywhere in the nuttx repository. It is for dealing with some erratum of the tms570, _errata_SSWF021_45_both_plls(). If we merge this PR it will be called _errata_sswf021_45_both_plls().
I don't see any place that it is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] hartmannathan commented on issue #773: Fix
suspect DEBUGASSERT() like PR765
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on issue #773: Fix suspect DEBUGASSERT() like PR765
URL: https://github.com/apache/incubator-nuttx/pull/773#issuecomment-612676268
> @hartmannathan You will need to fix the nxstyle complaints.
>
> Most likely the "Mixed case identifier" problems will not be fixable (unless they are fully local to the file). Otherwise, we can skip fixing the "Mixed case identifier" problems that span multiple files not included in the PR.
I just pushed a commit that fixes the nxstyle complaints.
I fixed the mixed case identifiers as well. They were fully local to the file.
One of them was a non-static function that does not appear to be called from anywhere in the nuttx repository. It is for dealing with some erratum of the tms570, _errata_SSWF021_45_both_plls(). If we merge this PR it will be called _errata_sswf021_45_both_plls().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo edited a comment on issue #773: Fix
suspect DEBUGASSERT() like PR765
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #773: Fix suspect DEBUGASSERT() like PR765
URL: https://github.com/apache/incubator-nuttx/pull/773#issuecomment-612665081
@hartmannathan You will need to fix the nxstyle complaints.
Most likely the "Mixed case identifier" problems will not be fixable (unless they are fully local to the file). Otherwise, we can skip fixing the "Mixed case identifier" problems that span multiple files not included in the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services