You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "dweiss (via GitHub)" <gi...@apache.org> on 2025/07/07 11:19:42 UTC
[PR] Rename the generated apijar files to -api.jar [lucene]
dweiss opened a new pull request, #14909:
URL: https://github.com/apache/lucene/pull/14909
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Rename the generated apijar files to -api.jar [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #14909:
URL: https://github.com/apache/lucene/pull/14909#issuecomment-3044609447
Checking if smoke tester is happy -
https://github.com/apache/lucene/actions/workflows/run-nightly-smoketester.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Rename the generated apijar files to -api.jar [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #14909:
URL: https://github.com/apache/lucene/pull/14909#issuecomment-3044580393
> Looks good. I expect `dev-tools/scripts/smokeTestRelease.py:630` to complain, but we can fix it.
I think this only checks the top-level files? I keep an eye on the nightly run for this so if it complains, I'll follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Rename the generated apijar files to -api.jar [lucene]
Posted by "rmuir (via GitHub)" <gi...@apache.org>.
rmuir commented on PR #14909:
URL: https://github.com/apache/lucene/pull/14909#issuecomment-3044593844
@dweiss here would be my proposed mod (a bit hacky, but it should do the trick if we need)
```diff
diff --git a/dev-tools/scripts/smokeTestRelease.py b/dev-tools/scripts/smokeTestRelease.py
index fbcb0586cd2..17b816162fc 100755
--- a/dev-tools/scripts/smokeTestRelease.py
+++ b/dev-tools/scripts/smokeTestRelease.py
@@ -633,7 +633,7 @@ def verifyUnpacked(java: Any, artifact: str, unpackPath: str, gitRevision: str,
if isSrc:
print(" make sure no JARs/WARs in src dist...")
- lines = os.popen("find . -name \\*.jar").readlines()
+ lines = os.popen("find . -name \\*.jar -not -name \\*-api.jar").readlines()
if len(lines) != 0:
print(" FAILED:")
for line in lines:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Rename the generated apijar files to -api.jar [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #14909:
URL: https://github.com/apache/lucene/pull/14909#issuecomment-3044601831
Oh, I see it now. I'll add it with the reference to this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Rename the generated apijar files to -api.jar [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss merged PR #14909:
URL: https://github.com/apache/lucene/pull/14909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org