You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "rgolangh (via GitHub)" <gi...@apache.org> on 2024/05/27 16:08:22 UTC

[PR] kogito-serverless-operator: generate stable names for workflow resources [incubator-kie-tools]

rgolangh opened a new pull request, #2375:
URL: https://github.com/apache/incubator-kie-tools/pull/2375

   Motivation:
   Workflowproj generates a configmap per schema or subflow or specs in a
   separate file for each one, however the name is not deterministic. In
   one iteration you can get the specs in
   01-configmap-FLOWNAME-resources.yaml and in the next iteration the same
   content will go in 02-configmap-FLOWNAME-resources.yaml.
   
   While the flow spec file will be updated accordingly and stay correct,
   the behaviour generates lots of changes when tracking changes in git.
   
   Modification:
   This fix will make the generation behaviour deterministic by sorting the
   resources iteration prior to generating them and also add the related
   schemas|specs/subflows to the generated file name:
   
   Result:
   old schema configmap manifest:
   0x-configmap-FLOWNAME-resources.yaml
   
   new schema configmap manifest:
   01-configmap-FLOWNAME-resources-schemas.yaml
   
   old specs config map manifest:
   0x-configmap-FLOWNAME-resources.yaml
   
   new specs configmap manifest:
   02-configmap-FLOWNAME-resources-specs.yaml
   
   old subflows config map manifest:
   0x-configmap-FLOWNAME-resources.yaml
   
   new subflows configmap manifest:
   01-configmap-FLOWNAME-resources-subflows.yaml
   
   Also the name of the config map itself will get the name related to the
   content like: '03-FLOWNAME-resources-schemas'
   
   Signed-off-by: Roy Golan <rg...@redhat.com>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] NO-ISSUE: sonataflow-operator: generate stable names for workflow resources [incubator-kie-tools]

Posted by "rgolangh (via GitHub)" <gi...@apache.org>.
rgolangh commented on PR #2375:
URL: https://github.com/apache/incubator-kie-tools/pull/2375#issuecomment-2184912375

   @tiagobento @ricardozanini can you please merge this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kogito-serverless-operator: generate stable names for workflow resources [incubator-kie-tools]

Posted by "rgolangh (via GitHub)" <gi...@apache.org>.
rgolangh commented on PR #2375:
URL: https://github.com/apache/incubator-kie-tools/pull/2375#issuecomment-2135211487

   > Can you also please backport this change to https://github.com/apache/incubator-kie-kogito-serverless-operator/?
   
   https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/473


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kogito-serverless-operator: generate stable names for workflow resources [incubator-kie-tools]

Posted by "rgolangh (via GitHub)" <gi...@apache.org>.
rgolangh commented on PR #2375:
URL: https://github.com/apache/incubator-kie-tools/pull/2375#issuecomment-2133791814

   @masayag 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kogito-serverless-operator: generate stable names for workflow resources [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2375:
URL: https://github.com/apache/incubator-kie-tools/pull/2375#issuecomment-2135237167

   There seems to be tests failing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] NO-ISSUE: sonataflow-operator: generate stable names for workflow resources [incubator-kie-tools]

Posted by "rgolangh (via GitHub)" <gi...@apache.org>.
rgolangh commented on PR #2375:
URL: https://github.com/apache/incubator-kie-tools/pull/2375#issuecomment-2151445737

   I fixed the unsorted imports now, they look exactly as the PR to the operator https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/473
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org