You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/26 11:33:02 UTC

[GitHub] [pulsar] Nicklee007 opened a new pull request, #16799: [fix][flaky-test]Fix flaky test in PulsarSinkE2ETest.testPulsarSinkDLQ

Nicklee007 opened a new pull request, #16799:
URL: https://github.com/apache/pulsar/pull/16799

   Fixes #16578
   
   ### Motivation
   Fix flaky test in PulsarSinkE2ETest.testPulsarSinkDLQ which sometime run failed , because the msg not show in dlqTopic.
   
   
   ### Modifications
   1. Wait all msg show in dlqTopic.
   
   
   ### Documentation
   - [X] `doc-not-needed` 
   (Please explain why)
     


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] RobertIndie commented on a diff in pull request #16799: [fix][flaky-test]Fix flaky test in PulsarSinkE2ETest.testPulsarSinkDLQ

Posted by GitBox <gi...@apache.org>.
RobertIndie commented on code in PR #16799:
URL: https://github.com/apache/pulsar/pull/16799#discussion_r930560378


##########
pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarSinkE2ETest.java:
##########
@@ -189,6 +189,11 @@ public void testPulsarSinkDLQ() throws Exception {
             remainingMessagesToReceive.add(messageBody);
         }
 
+        // Wait all msg show in dlqTopic.
+        Awaitility.await().untilAsserted(()-> {
+            assertEquals(admin.topics().getLastMessageId(dlqTopic).toString(),"10:1:-1:8");

Review Comment:
   Can we guarantee that the message-id is the same for every testing? There is an exception in this PR:https://github.com/apache/pulsar/runs/7524494144?check_suite_focus=true#step:10:1231
   
   We can directly modify the wait time for the consumer to receive the message:
   https://github.com/apache/pulsar/pull/16799/files#diff-1be1a68c630a114a3f7770115053f58066cbf117b24d0e73903f6340f7aef793L194
   
   And I think the root cause may not be the timeout setting. 10 seconds should be enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 closed pull request #16799: [fix][flaky-test]Fix flaky test in PulsarSinkE2ETest.testPulsarSinkDLQ

Posted by GitBox <gi...@apache.org>.
Nicklee007 closed pull request #16799: [fix][flaky-test]Fix flaky test in PulsarSinkE2ETest.testPulsarSinkDLQ
URL: https://github.com/apache/pulsar/pull/16799


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Nicklee007 commented on a diff in pull request #16799: [fix][flaky-test]Fix flaky test in PulsarSinkE2ETest.testPulsarSinkDLQ

Posted by GitBox <gi...@apache.org>.
Nicklee007 commented on code in PR #16799:
URL: https://github.com/apache/pulsar/pull/16799#discussion_r930566303


##########
pulsar-broker/src/test/java/org/apache/pulsar/io/PulsarSinkE2ETest.java:
##########
@@ -189,6 +189,11 @@ public void testPulsarSinkDLQ() throws Exception {
             remainingMessagesToReceive.add(messageBody);
         }
 
+        // Wait all msg show in dlqTopic.
+        Awaitility.await().untilAsserted(()-> {
+            assertEquals(admin.topics().getLastMessageId(dlqTopic).toString(),"10:1:-1:8");

Review Comment:
   > Can we guarantee that the message-id is the same for every testing? There is an exception in this
   
   seems that you are right



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org