[jira] [Commented] (AURORA-1739) createJob thrift api for golang consistenly failing with empty CronSchedule

["Renan DelValle (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469144#comment-15469144 ] 

Renan DelValle commented on AURORA-1739:
----------------------------------------

I encountered this as well but, thankfully, [~jfarrell] lent me a hand with this.  I'm sure you've fixed this issue by now, but for anyone else this might help.

This can be fixed by modifying the thrift API from which the go bindings get created.

This line: https://github.com/apache/aurora/blob/master/api/src/main/thrift/org/apache/aurora/gen/api.thrift#L328

Has to be changed from:
{code}
  4: string cronSchedule
{code}
to:
{code}
  4: optional string cronSchedule
{code}

Maybe I should submit a patch for this but I have to see if this causes any issues when any other language's bindings are generated first.

> createJob thrift api for golang consistenly failing with empty CronSchedule
> ---------------------------------------------------------------------------
>
>                 Key: AURORA-1739
>                 URL: https://issues.apache.org/jira/browse/AURORA-1739
>             Project: Aurora
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 0.15.0
>            Reporter: Jimmy Wu
>            Priority: Critical
>
> trying to create non cron job via the thrift api for golang  but consistently getting error "Cron jobs may only be created/updated by calling scheduleCronJob.".  Root cause :  CronSchedule is not set in JobConfiguration hence an empty string is used, then create job request gets rejected because aurora now treats empty cron schedule as failure (related changes https://reviews.apache.org/r/28571/).  This issue breaks all createJob requests submitted from golang thrift api because empty string is default value for string instead of nil.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)