[jira] [Commented] (VCL-702) Rework code to use new subroutines and objects & general code cleanup for VCL 2.4

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/VCL-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335233#comment-14335233 ] 

ASF subversion and git services commented on VCL-702:
-----------------------------------------------------

Commit 1662080 from [~arkurth] in branch 'vcl/trunk'
[ https://svn.apache.org/r1662080 ]

Updated reserved.pm::process to check for a computerloadlog 'initialconnecttimeout' entry for the parent reservation ID. The frontend only inserts the entry for the parent. This was generating warnings.

VCL-174
Changed OS.pm::process_connect_methods to pass a string consisting of the vcld process name and reservation ID to add_nat_port_forward instead of just the reservation ID. This will make it easier to identify which firewall chains/rules were created by a particular vcld daemon.

Updated iptables.pm::get_table_info to parse the table information and create a hash reference.

VCL-678
Commented out unnecessary vcld.log messages in utils.pm::is_management_node_process_running.

VCL-702
Updated Linux.pm::activate_interfaces to use OS.pm::create_text_file. It had been calling echo with a \E argument to create ifcfg* files. The argument was generating warnings.

> Rework code to use new subroutines and objects & general code cleanup for VCL 2.4
> ---------------------------------------------------------------------------------
>
>                 Key: VCL-702
>                 URL: https://issues.apache.org/jira/browse/VCL-702
>             Project: VCL
>          Issue Type: Improvement
>          Components: vcld (backend)
>    Affects Versions: 2.3
>            Reporter: Andy Kurth
>            Assignee: Andy Kurth
>            Priority: Minor
>             Fix For: 2.4
>
>
> There are various places in the code where some old code is being used which can be replaced with newer improved code.  This issue is a catch-all for these.
> Examples:
> run_ssh_command -> $self->execute
> code_loop_timeout
> ALL PLACES WHERE 'GOTO' IS USED!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)