You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "iskenderulgen (via GitHub)" <gi...@apache.org> on 2024/03/10 10:30:59 UTC
[PR] feat: Add Turkey's regions to country map visualization #26423 [superset]
iskenderulgen opened a new pull request, #27455:
URL: https://github.com/apache/superset/pull/27455
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
In addition to Turkey's departmens, there is also need for Turkey's Regional map for geospatial statistical inference with organizational data. The regional polygons are created from city level polygon using geopandas.
* Original city-wise polygons are acquired from https://data.humdata.org/dataset/cod-ab-tur?
* ISO 3166-2 code is presented for city level such as TR-34 (Istanbul). However, after some search, there seems to be less or no information about Turkey's ISO 3166-2 codes for regional information. Region information is obtained from Nomenclature of Territorial Units for Statistics (NUTS) which has been widely used for Turkey since 2002. Turkish Statistical Institute (TUIK) provides board level information using NUTS codes which is of great benefit to oraganizations and companies. In view of the lack of ISO 3166-2 code information for Turkey at the region level and the wide use of NUTS codes, we associated 12 region polygons with NUTS representations for ISO and NAME_1 keys of geojson. For future if or when we can find ISO 3166-2 on region level, we can create new PR to change the data structure. Considering majority of the spatial data coming from TUIK, polygon will be easy to join with the TUIK data.
Ref= https://en.wikipedia.org/wiki/ISO_3166-2:TR
Ref=https://en.wikipedia.org/wiki/NUTS_statistical_regions_of_Turkey
* The data structure is as follows
* Original regions geojson was 13MB of size which could crash superset on production. To mitigate that problem, we used simplify(tolerance=0.005, preserve_topology=True). After simplification the accuracy of the polygons are checked againts the original file with the area functions and the difference was -0.01, which is acceptible considering the size reduction from 13mb to 448kb.
* The geojson file follows the same structure with Italy's regions such as "urn:ogc:def:crs:OGC:1.3:CRS84".
* Gejson file both tested with locally on python environment and with Apache Superset 3.1 version. Images are presented as follows.
* Upon acceptance of the Region based feature addition. Sub regional data (26 region) and district level (973) polygons will be PR'ed with NUTS codes from TUIK institution. With these features complete granularity will be added to Apache superset for Turkey's locations.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
## Turkey's cities geojson file which is used to create regional based polygons.
## Turkey's regional polygon file after merging cities into regions.
### Base plot from matplotlib
### Colored plot from matplotlib
### Apache superset dev-environment test image on local test
* test is conducted by creating a new table and iserting toy data that matches the ISO (NUTS) codes.
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #26423
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "iskenderulgen (via GitHub)" <gi...@apache.org>.
iskenderulgen commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1990962036
Hi, i updated the branch to be in sync with superset:master, but have no clue why npm unit test is failing.
The reason maps sizes are different is that, the first commit that included geojson (which is tested with superset development using docker) comes from OCHA HDX database. HDX Geojson was updated 202103 and the geospatial analytics team keeps the hdx database updated as the new changes arrives (we also use these adm1 - adm2 - adm3 maps in our local prod environments, wanted to share json files with rest of the users). Thus, the map has more detailed representation for borders and we used these adm1 level data to create regions. Jupyter notebook uses natural earth data, even though we used same code on jupyter notebook, natural earth data has some differences on adm1 level. In the picture below we compared Ocha hdx, Natural earth and [Wiki page](https://en.wikipedia.org/wiki/NUTS_statistical_regions_of_Turkey) region map data and marked some differences. If possible we would like to contribute with the json file created from HDX and keep code base on jupyter notebook as requested.
Size difference is approximately 150KB (HDX is 338KB and Natural earth data is 190KB). Would like to help if you have any other questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "iskenderulgen (via GitHub)" <gi...@apache.org>.
iskenderulgen commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1994022042
Hi, as requested i changed the map source to the UN OCHA HDX data location. The data is stored under COD (Common Operational Dataset) which aligns with Apache open source licences. Updated the jupyter notebook and merged some cells to have clean workflow. Local test shows no error for jupyter notebook.
Notebook has differen simplification tresholds for each map size, so also updated the geojson file creted from jupyter notebook. Countries.ts file also derives some minor code change from notebook, commited the minor code change along with new geojson file. All changes are committed seperately for atomicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #27455:
URL: https://github.com/apache/superset/pull/27455#discussion_r1524004521
##########
superset-frontend/plugins/legacy-plugin-chart-country-map/src/countries.ts:
##########
@@ -221,13 +223,10 @@ export const countryOptions = Object.keys(countries).map(x => {
if (x === 'france_regions') {
return [x, 'France (regions)'];
}
- return [
- x,
- x
- .split('_')
- .map(e => e[0].toUpperCase() + e.slice(1))
- .join(' '),
- ];
+ if (x === 'turkey_regions') {
+ return [x, 'Turkey (regions)'];
+ }
+ return [x, x.split('_').map((e) => e[0].toUpperCase() + e.slice(1)).join(' ')];
Review Comment:
This last part is formatted poorly in the Jupyter notebook (my fault, I'm sorry!). It normally gets cleaned up by eslint/prettier, but we should probably fix it in the notebook itself to be formatted like so:
```
return [
x,
x
.split('_')
.map(e => e[0].toUpperCase() + e.slice(1))
.join(' '),
];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1997724671
Approving CI... I'll approve and merge when possible. I was going to do a little notebook tidying, but you're welcome to make your changes first if you'd like.
I haven't looked into the `italy_regions` map either, by the way. That's the only one left that isn't pulling from NaturalEarth data, if you want to contribute that so that we're finally 100% notebook-derived in our maps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "iskenderulgen (via GitHub)" <gi...@apache.org>.
iskenderulgen commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1996394761
hi, i inspected the HDX project metadata and the only licence indication was "[other : Shared by the General Command of Mapping for humanitarian use only](https://data.humdata.org/dataset/cod-ab-tur?)" not much to detail about it and also HDX was not clear what "[other](https://data.humdata.org/faqs/licenses)" license mean. So for compatibility i reverted back to natural earth polygon for regions location.
Also updated the notebook lint section to have same export that we had on the older commits this should solve the problem you commented. Also overwritten the hdx polygon with the data coming from natural earth file is now 107kb size. After commit i run the notebook again and the file output seems to be same on my setup. If you can elaborate the file difference on your end, happy to help to that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "iskenderulgen (via GitHub)" <gi...@apache.org>.
iskenderulgen commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1996789880
Could there be a dependency problem with npm package, front-end check is in progress like 3 hours and 30 minutes. Also is there a something else that i should be working on to merge-close pr. Until official approval arrives from HDX we can use natural earh polygons for regions map. After approval i can start to work on polygons for all granularity on jupyter to update maps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1998398195
I'll reach out and follow up! Lemme open a quick PR on the notebook, and then you're welcome to pull it and keep going on Italy regions or anything else :) I very much appreciate the help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1989638765
There's a seemingly unrelated unit test here that keeps failing... would you mind rebasing?
Also, when I run the notebook locally, the geojson file that's generated by the notebook is different (and smaller?) than the one on this PR. I'm not sure what's up with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "iskenderulgen (via GitHub)" <gi...@apache.org>.
iskenderulgen commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1996602950
I'll inspect the zip file that you provided and make area comparison of each region in case there is difference that requires handling. It would be really nice if it could be confirmed from HDX. I'll keep the HDX codebase and if HDX is usable for the project I can update in quick pr.
Since there is no district level data on natural earth apart from USA, it could be usefull to include HDX db for detailed granularity. Alternative is I can use natural earth for region and sub_region but will need to switch to openstreemap for district level polygons. Best case is, up on agreement with HDX i can create all 4 maps (region - sub region - city level - district level) from one URL and one database. thanks for the help in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1996051625
Hi there, and thanks for keeping this progressing. There are a couple of issues to contend with:
* It's not clear that the licensing is compatible. Is [this](https://data.humdata.org/dataset/cod-ab-tur) the best reference regarding the license? All it says, really, is that it's for humanitarian use only. I'm not sure if we qualify? Maybe! We might have to get ASF to weigh in ¯\_(ツ)_/¯
* The PR is not passing the linter checks... I added a comment on the PR about this, but we might as well fix it in the notebook so it outputs properly formatted code, rather than relying on the linter. Feel free to either fix the notebook, or just run the [pre-commit hooks](https://superset.apache.org/docs/contributing/hooks-and-linting/). Either way can get the PR across the finish line.
• I just ran the updated notebook, and it appears the geojson file the notebook outputs doesn't match what's on the PR. Not sure what's up with that difference.
I wish it were easier to collaborate on this notebook, so I didn't have to ask for these changes. The process is getting better, but is not yet perfect :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1987595400
Hi there... we're trying to manage all map contributions through the Jupyter notebook, to make this area of the codebase more maintainable. Would you be willing to contribute the changes through there, so that we can more easily maintain this (and other) GeoJSON files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "iskenderulgen (via GitHub)" <gi...@apache.org>.
iskenderulgen commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1998054877
I have no prior communucation with HDX management team, if you could I believe you can get faster response.
for italy regions upon compilation of this pr I'll do some local work and some code try-outs to get the hang of italy regions (excepting some language barrier with the region names) and append changes to the notebook. After italy i can do some cleanup on the notebook and ask for review.
Later on planning to do some contribution on language wise. This issue #24603 was created by one of our co-workers maybe i can add some turkish support and try to improve the horizontal time axis representation.
Planning to follow discussion - issue - pr workflow with small time span to keep issue list clear. Thanks for the help along the review process :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1991932424
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/27455?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 67.36%. Comparing base [(`2a5b5fe`)](https://app.codecov.io/gh/apache/superset/commit/2a5b5fe0498bfa9359b8761a0df13a0ce2589645?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`3580c61`)](https://app.codecov.io/gh/apache/superset/pull/27455?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #27455 +/- ##
=======================================
Coverage 67.36% 67.36%
=======================================
Files 1909 1909
Lines 74678 74680 +2
Branches 8325 8326 +1
=======================================
+ Hits 50309 50311 +2
Misses 22318 22318
Partials 2051 2051
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/27455/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/27455/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.21% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/27455?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1991903916
Hi again, and thanks for the continued engagement here. Indeed, we want to keep things as accurate (and fair) as possible when it comes to map data. If HDX is license-compatible with Apache projects (which seems to depend on the file), geopolitically uncontroversial (i.e. both sides win in a border dispute) and more accurate, then that's great! I think its be great to have the Jupyter notebook pull that from HDX as part of the notebook workflow, and perhaps add a clear link to a compatible license in the notebook comments or something along those lines. We're just trying to have a single point of maintenance for all this, and it's not good if the notebook generates a map that overwrites something superior :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #27455:
URL: https://github.com/apache/superset/pull/27455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1996587059
Hmm... weird. The geojson that I get as a result from my own notebook run (after pulling your latest changes) is also 107k. It's not an easy diff to make sense of, so I'll add a ZIP of it here in case you're able to spot something.
[turkey_regions.geojson.zip](https://github.com/apache/superset/files/14597228/turkey_regions.geojson.zip)
It sure would be nice to use this HDX data (which keeps making me think of [Home Depot](https://www.homedepot.com/b/HDX/N-5yc1vZ9tk)) - maybe one of us can concat them and/or ASF to see if it is indeed usable. The more current and geopolitically acceptable our data is, the better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "iskenderulgen (via GitHub)" <gi...@apache.org>.
iskenderulgen commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1987742771
Hi, I'll check the jupyter file to move the process there. Only problem might be the ISO_3166-2:TR code for Turkey since they are not exist. If i can tackle with custom dictionary for NUTS codes, i'll update the codebase otherwise i'll need to stick with the custom created json file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1997727152
Were you planning to reach out to the HDX team for clarity on the license, or shall I?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat: Add Turkey's regions to country map visualization [superset]
Posted by "iskenderulgen (via GitHub)" <gi...@apache.org>.
iskenderulgen commented on PR #27455:
URL: https://github.com/apache/superset/pull/27455#issuecomment-1988370115
@rusackas hello, the additions you requested are appended to the map generator notebook. Since there is no ISO codes for the country, NUTS codes are used for regions and a dictionary constructured to map cities into regions. Notebook tested locally and faced with no error. As mentioned above if / when ISO codes made available for Turkey i will make neccessary changes with new PR, until than, NUTS codes from TUIK institue will be used for all granularity apart from city-level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org