You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by Claude Brisson <cl...@renegat.net> on 2007/01/03 09:24:12 UTC
Re: svn commit: r491783 - in /velocity/engine/trunk/build:
build.properties
Le mercredi 03 janvier 2007 à 00:50 +0000, Henning P. Schmiedehausen a
écrit :
> cbrisson@apache.org writes:
>
> Hi,
>
> while I'm basically +1 for the patch (lazy consensus), can you please
> document each of the properties inside build.properties. ATM they seem
> to be self-explanatory but in six months, we might wonder about the
> interactions...
Ok, I'll add details.
> Does the default setting break Gump?
That's a very good question. It's impossible to test that right now
since commons-lang is broken since yesterday. Plus, I'm now worried it
might even be worse: it could not break Gump but only change the way it
works (by not using @@DATE@@ versions of the dependencies). Since there
already are some properties that are present in build.properties and
overridden in Gump's velocity-engine.xml I think it should be ok, but is
there anyway to check that?
By the way, engine test is broken on my box (Linux, Java 1.5.0_06-b05):
Didn't see introspector cache dump.
junit.framework.AssertionFailedError: Didn't see introspector cache
dump.
at
org.apache.velocity.test.ClassloaderChangeTestCase.testClassloaderChange(ClassloaderChangeTestCase.java:136)
Claude
> Best regards
> Henning
>
>
>
> >Author: cbrisson
> >Date: Tue Jan 2 04:21:11 2007
> >New Revision: 491783
>
> >URL: http://svn.apache.org/viewvc?view=rev&rev=491783
> >Log:
> >skip.jar.loading and force.jar.loading now have a consistent behaviour (VELOCITY-502)
>
> >Modified:
> > velocity/engine/trunk/build/build.properties
> > velocity/engine/trunk/build/download.xml
>
> >Modified: velocity/engine/trunk/build/build.properties
> >URL: http://svn.apache.org/viewvc/velocity/engine/trunk/build/build.properties?view=diff&rev=491783&r1=491782&r2=491783
> >==============================================================================
> >--- velocity/engine/trunk/build/build.properties (original)
> >+++ velocity/engine/trunk/build/build.properties Tue Jan 2 04:21:11 2007
> >@@ -68,6 +68,10 @@
> > test.haltonerror= true
> > test.haltonfailure= true
> >
> >+#downloading dependency jars
> >+skip.jar.loading= false
> >+force.jar.loading= true
> >+
> > # Building the distribution
> > dist.root= ${build.dir}/dist
> > dist.dir= ${dist.root}/${final.name}
>
> >Modified: velocity/engine/trunk/build/download.xml
> >URL: http://svn.apache.org/viewvc/velocity/engine/trunk/build/download.xml?view=diff&rev=491783&r1=491782&r2=491783
> >==============================================================================
> >--- velocity/engine/trunk/build/download.xml (original)
> >+++ velocity/engine/trunk/build/download.xml Tue Jan 2 04:21:11 2007
> >@@ -45,7 +45,20 @@
> > <antcall target="junit-download" />
> > </target>
> >
> >- <target name="http-download" unless="skip.jar.loading">
> >+ <target name="http-download">
> >+ <condition property="skip-download">
> >+ <or>
> >+ <istrue value="${skip.jar.loading}"/>
> >+ <and>
> >+ <isfalse value="${force.jar.loading}"/>
> >+ <available file="${build.lib}/${download.jarname}-${download.jarversion}.jar"/>
> >+ </and>
> >+ </or>
> >+ </condition>
> >+ <antcall target="do-http-download"/>
> >+ </target>
> >+
> >+ <target name="do-http-download" unless="skip-download">
> > <setproxy proxyhost="${proxy.host}" proxyport="${proxy.port}"/>
> > <get src="${repo.url}/${download.jarname}/jars/${download.jarname}-${download.jarversion}.jar"
> > dest="${build.lib}/${download.jarname}-${download.jarversion}.jar"
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: svn commit: r491783 - in /velocity/engine/trunk/build:
build.properties
Posted by Claude Brisson <cl...@renegat.net>.
Le vendredi 05 janvier 2007 à 09:24 +0100, Claude Brisson a écrit :
> Le mercredi 03 janvier 2007 à 09:24 +0100, Claude Brisson a écrit :
> > Le mercredi 03 janvier 2007 à 00:50 +0000, Henning P. Schmiedehausen a
> > > Does the default setting break Gump?
> >
> > That's a very good question. It's impossible to test that right now
> > since commons-lang is broken since yesterday. Plus, I'm now worried it
> > might even be worse: it could not break Gump but only change the way it
> > works (by not using @@DATE@@ versions of the dependencies). Since there
> > already are some properties that are present in build.properties and
> > overridden in Gump's velocity-engine.xml I think it should be ok, but is
> > there anyway to check that?
>
> Ok, so the default setting DOES break Gump build.
Ah sorry. No, it does not break Gump since its "skip.jar.loading=true"
setting is taken into account. It just looks like commons-lang is not
yet ready...
Claude
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: svn commit: r491783 - in /velocity/engine/trunk/build:
build.properties
Posted by Claude Brisson <cl...@renegat.net>.
Le mercredi 03 janvier 2007 à 09:24 +0100, Claude Brisson a écrit :
> Le mercredi 03 janvier 2007 à 00:50 +0000, Henning P. Schmiedehausen a
> > Does the default setting break Gump?
>
> That's a very good question. It's impossible to test that right now
> since commons-lang is broken since yesterday. Plus, I'm now worried it
> might even be worse: it could not break Gump but only change the way it
> works (by not using @@DATE@@ versions of the dependencies). Since there
> already are some properties that are present in build.properties and
> overridden in Gump's velocity-engine.xml I think it should be ok, but is
> there anyway to check that?
Ok, so the default setting DOES break Gump build.
I'm just gonna comment those flags out of build.properties to make Gump
happy.
Claude
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: svn commit: r491783 - in /velocity/engine/trunk/build:
build.properties
Posted by Claude Brisson <cl...@renegat.net>.
Le jeudi 04 janvier 2007 à 07:14 -0800, Will Glass-Husain a écrit :
> FYI. I fixed a build problem in which the hsqldb/junit jars weren't
> being properly downloaded.
>
> I ran "ant test" (win xp/JDK 1.5/ant 1.6.2) and it passed. Is the
> build still broken on your end?
Yes, that fixed the problem - I should have noticed the
http-test-download target and patched it as well.
Oh, by the way, the <junit> task is said to be able to find junit.jar in
its classpath only since ant 1.7.0, which would mean that your version
of ant is using another junit.jar (ant's one if any). This affects only
<junit>, not the compilation of the test classes. I spent some time
understanding this...
Claude
> WILL
>
> On 1/3/07, Claude Brisson <cl...@renegat.net> wrote:
> > Le mercredi 03 janvier 2007 à 00:50 +0000, Henning P. Schmiedehausen a
> > écrit :
> > > cbrisson@apache.org writes:
> > >
> > > Hi,
> > >
> > > while I'm basically +1 for the patch (lazy consensus), can you please
> > > document each of the properties inside build.properties. ATM they seem
> > > to be self-explanatory but in six months, we might wonder about the
> > > interactions...
> >
> > Ok, I'll add details.
> >
> > > Does the default setting break Gump?
> >
> > That's a very good question. It's impossible to test that right now
> > since commons-lang is broken since yesterday. Plus, I'm now worried it
> > might even be worse: it could not break Gump but only change the way it
> > works (by not using @@DATE@@ versions of the dependencies). Since there
> > already are some properties that are present in build.properties and
> > overridden in Gump's velocity-engine.xml I think it should be ok, but is
> > there anyway to check that?
> >
> > By the way, engine test is broken on my box (Linux, Java 1.5.0_06-b05):
> >
> > Didn't see introspector cache dump.
> > junit.framework.AssertionFailedError: Didn't see introspector cache
> > dump.
> > at
> > org.apache.velocity.test.ClassloaderChangeTestCase.testClassloaderChange(ClassloaderChangeTestCase.java:136)
> >
> >
> >
> > Claude
> >
> > > Best regards
> > > Henning
> > >
> > >
> > >
> > > >Author: cbrisson
> > > >Date: Tue Jan 2 04:21:11 2007
> > > >New Revision: 491783
> > >
> > > >URL: http://svn.apache.org/viewvc?view=rev&rev=491783
> > > >Log:
> > > >skip.jar.loading and force.jar.loading now have a consistent behaviour (VELOCITY-502)
> > >
> > > >Modified:
> > > > velocity/engine/trunk/build/build.properties
> > > > velocity/engine/trunk/build/download.xml
> > >
> > > >Modified: velocity/engine/trunk/build/build.properties
> > > >URL: http://svn.apache.org/viewvc/velocity/engine/trunk/build/build.properties?view=diff&rev=491783&r1=491782&r2=491783
> > > >==============================================================================
> > > >--- velocity/engine/trunk/build/build.properties (original)
> > > >+++ velocity/engine/trunk/build/build.properties Tue Jan 2 04:21:11 2007
> > > >@@ -68,6 +68,10 @@
> > > > test.haltonerror= true
> > > > test.haltonfailure= true
> > > >
> > > >+#downloading dependency jars
> > > >+skip.jar.loading= false
> > > >+force.jar.loading= true
> > > >+
> > > > # Building the distribution
> > > > dist.root= ${build.dir}/dist
> > > > dist.dir= ${dist.root}/${final.name}
> > >
> > > >Modified: velocity/engine/trunk/build/download.xml
> > > >URL: http://svn.apache.org/viewvc/velocity/engine/trunk/build/download.xml?view=diff&rev=491783&r1=491782&r2=491783
> > > >==============================================================================
> > > >--- velocity/engine/trunk/build/download.xml (original)
> > > >+++ velocity/engine/trunk/build/download.xml Tue Jan 2 04:21:11 2007
> > > >@@ -45,7 +45,20 @@
> > > > <antcall target="junit-download" />
> > > > </target>
> > > >
> > > >- <target name="http-download" unless="skip.jar.loading">
> > > >+ <target name="http-download">
> > > >+ <condition property="skip-download">
> > > >+ <or>
> > > >+ <istrue value="${skip.jar.loading}"/>
> > > >+ <and>
> > > >+ <isfalse value="${force.jar.loading}"/>
> > > >+ <available file="${build.lib}/${download.jarname}-${download.jarversion}.jar"/>
> > > >+ </and>
> > > >+ </or>
> > > >+ </condition>
> > > >+ <antcall target="do-http-download"/>
> > > >+ </target>
> > > >+
> > > >+ <target name="do-http-download" unless="skip-download">
> > > > <setproxy proxyhost="${proxy.host}" proxyport="${proxy.port}"/>
> > > > <get src="${repo.url}/${download.jarname}/jars/${download.jarname}-${download.jarversion}.jar"
> > > > dest="${build.lib}/${download.jarname}-${download.jarversion}.jar"
> > >
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> > For additional commands, e-mail: dev-help@velocity.apache.org
> >
> >
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
Re: svn commit: r491783 - in /velocity/engine/trunk/build: build.properties
Posted by Will Glass-Husain <wg...@forio.com>.
FYI. I fixed a build problem in which the hsqldb/junit jars weren't
being properly downloaded.
I ran "ant test" (win xp/JDK 1.5/ant 1.6.2) and it passed. Is the
build still broken on your end?
WILL
On 1/3/07, Claude Brisson <cl...@renegat.net> wrote:
> Le mercredi 03 janvier 2007 à 00:50 +0000, Henning P. Schmiedehausen a
> écrit :
> > cbrisson@apache.org writes:
> >
> > Hi,
> >
> > while I'm basically +1 for the patch (lazy consensus), can you please
> > document each of the properties inside build.properties. ATM they seem
> > to be self-explanatory but in six months, we might wonder about the
> > interactions...
>
> Ok, I'll add details.
>
> > Does the default setting break Gump?
>
> That's a very good question. It's impossible to test that right now
> since commons-lang is broken since yesterday. Plus, I'm now worried it
> might even be worse: it could not break Gump but only change the way it
> works (by not using @@DATE@@ versions of the dependencies). Since there
> already are some properties that are present in build.properties and
> overridden in Gump's velocity-engine.xml I think it should be ok, but is
> there anyway to check that?
>
> By the way, engine test is broken on my box (Linux, Java 1.5.0_06-b05):
>
> Didn't see introspector cache dump.
> junit.framework.AssertionFailedError: Didn't see introspector cache
> dump.
> at
> org.apache.velocity.test.ClassloaderChangeTestCase.testClassloaderChange(ClassloaderChangeTestCase.java:136)
>
>
>
> Claude
>
> > Best regards
> > Henning
> >
> >
> >
> > >Author: cbrisson
> > >Date: Tue Jan 2 04:21:11 2007
> > >New Revision: 491783
> >
> > >URL: http://svn.apache.org/viewvc?view=rev&rev=491783
> > >Log:
> > >skip.jar.loading and force.jar.loading now have a consistent behaviour (VELOCITY-502)
> >
> > >Modified:
> > > velocity/engine/trunk/build/build.properties
> > > velocity/engine/trunk/build/download.xml
> >
> > >Modified: velocity/engine/trunk/build/build.properties
> > >URL: http://svn.apache.org/viewvc/velocity/engine/trunk/build/build.properties?view=diff&rev=491783&r1=491782&r2=491783
> > >==============================================================================
> > >--- velocity/engine/trunk/build/build.properties (original)
> > >+++ velocity/engine/trunk/build/build.properties Tue Jan 2 04:21:11 2007
> > >@@ -68,6 +68,10 @@
> > > test.haltonerror= true
> > > test.haltonfailure= true
> > >
> > >+#downloading dependency jars
> > >+skip.jar.loading= false
> > >+force.jar.loading= true
> > >+
> > > # Building the distribution
> > > dist.root= ${build.dir}/dist
> > > dist.dir= ${dist.root}/${final.name}
> >
> > >Modified: velocity/engine/trunk/build/download.xml
> > >URL: http://svn.apache.org/viewvc/velocity/engine/trunk/build/download.xml?view=diff&rev=491783&r1=491782&r2=491783
> > >==============================================================================
> > >--- velocity/engine/trunk/build/download.xml (original)
> > >+++ velocity/engine/trunk/build/download.xml Tue Jan 2 04:21:11 2007
> > >@@ -45,7 +45,20 @@
> > > <antcall target="junit-download" />
> > > </target>
> > >
> > >- <target name="http-download" unless="skip.jar.loading">
> > >+ <target name="http-download">
> > >+ <condition property="skip-download">
> > >+ <or>
> > >+ <istrue value="${skip.jar.loading}"/>
> > >+ <and>
> > >+ <isfalse value="${force.jar.loading}"/>
> > >+ <available file="${build.lib}/${download.jarname}-${download.jarversion}.jar"/>
> > >+ </and>
> > >+ </or>
> > >+ </condition>
> > >+ <antcall target="do-http-download"/>
> > >+ </target>
> > >+
> > >+ <target name="do-http-download" unless="skip-download">
> > > <setproxy proxyhost="${proxy.host}" proxyport="${proxy.port}"/>
> > > <get src="${repo.url}/${download.jarname}/jars/${download.jarname}-${download.jarversion}.jar"
> > > dest="${build.lib}/${download.jarname}-${download.jarversion}.jar"
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
> For additional commands, e-mail: dev-help@velocity.apache.org
>
>
--
Forio Business Simulations
Will Glass-Husain
wglass@forio.com
www.forio.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org