You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by Xiangying Meng <xi...@apache.org> on 2024/04/07 11:12:59 UTC
[DISCUSS] cherry-pick #22034 Create new ledger after the current ledger is closed
Hi all,
I want to start a discussion to cherry-pick #22034 [0] to release branches.
The PR creates a new ledger after the current one is full. This is a
bug fix to resolve the issue where the last ledger could not be
deleted after expiration. Moreover, since there is no need to create a
new ledger only when messages are sent, it can reduce the send
latency.
However, it could be a behavior change and introduce some flaky tests
we have fixed in the master. So I think it may be necessary to have a
discussion before cherry-picking.
The target branches:
- branch-3.0
- branch-3.1
- branch-3.2
[0] https://github.com/apache/pulsar/pull/22034
I will keep the discussion open for at least 48 hours.
If there is no objections, I will perform the cherry-picking.
BR,
Xiangying
Re: [DISCUSS] cherry-pick #22034 Create new ledger after the current ledger is closed
Posted by PengHui Li <pe...@apache.org>.
It sounds good to me.
Regards,
Penghui
On Thu, Apr 11, 2024 at 9:05 PM Baodi Shi <ba...@apache.org> wrote:
> Hi, xiangying.
>
> I agree with cherry-picking the historical branch. This change in behavior
> is as expected, and it can indeed be understood as a bug.
>
> We can cherry-pick them all together after fixing all unstable tests.
>
> Currently, the only test I see is this one:
> - https://github.com/apache/pulsar/issues/22351
>
>
> Thanks,
> Baodi Shi
>
>
> On Apr 7, 2024 at 19:12:59, Xiangying Meng <xi...@apache.org> wrote:
>
> > Hi all,
> >
> > I want to start a discussion to cherry-pick #22034 [0] to release
> branches.
> > The PR creates a new ledger after the current one is full. This is a
> > bug fix to resolve the issue where the last ledger could not be
> > deleted after expiration. Moreover, since there is no need to create a
> > new ledger only when messages are sent, it can reduce the send
> > latency.
> >
> > However, it could be a behavior change and introduce some flaky tests
> > we have fixed in the master. So I think it may be necessary to have a
> > discussion before cherry-picking.
> >
> > The target branches:
> >
> > - branch-3.0
> > - branch-3.1
> > - branch-3.2
> >
> > [0] https://github.com/apache/pulsar/pull/22034
> >
> > I will keep the discussion open for at least 48 hours.
> > If there is no objections, I will perform the cherry-picking.
> >
> > BR,
> > Xiangying
> >
>
Re: [DISCUSS] cherry-pick #22034 Create new ledger after the current ledger is closed
Posted by Baodi Shi <ba...@apache.org>.
Hi, xiangying.
I agree with cherry-picking the historical branch. This change in behavior
is as expected, and it can indeed be understood as a bug.
We can cherry-pick them all together after fixing all unstable tests.
Currently, the only test I see is this one:
- https://github.com/apache/pulsar/issues/22351
Thanks,
Baodi Shi
On Apr 7, 2024 at 19:12:59, Xiangying Meng <xi...@apache.org> wrote:
> Hi all,
>
> I want to start a discussion to cherry-pick #22034 [0] to release branches.
> The PR creates a new ledger after the current one is full. This is a
> bug fix to resolve the issue where the last ledger could not be
> deleted after expiration. Moreover, since there is no need to create a
> new ledger only when messages are sent, it can reduce the send
> latency.
>
> However, it could be a behavior change and introduce some flaky tests
> we have fixed in the master. So I think it may be necessary to have a
> discussion before cherry-picking.
>
> The target branches:
>
> - branch-3.0
> - branch-3.1
> - branch-3.2
>
> [0] https://github.com/apache/pulsar/pull/22034
>
> I will keep the discussion open for at least 48 hours.
> If there is no objections, I will perform the cherry-picking.
>
> BR,
> Xiangying
>
Re: [DISCUSS] cherry-pick #22034 Create new ledger after the current ledger is closed
Posted by Yubiao Feng <yu...@streamnative.io.INVALID>.
Hi Xiangying
I think before we cherry-pick this PR, we should check why it introduced a
Flaky test https://github.com/apache/pulsar/issues/22351, we need to
confirm whether this raises other issues.
Thanks
Yubiao Feng
On Sun, Apr 7, 2024 at 7:13 PM Xiangying Meng <xi...@apache.org> wrote:
> Hi all,
>
> I want to start a discussion to cherry-pick #22034 [0] to release branches.
> The PR creates a new ledger after the current one is full. This is a
> bug fix to resolve the issue where the last ledger could not be
> deleted after expiration. Moreover, since there is no need to create a
> new ledger only when messages are sent, it can reduce the send
> latency.
>
> However, it could be a behavior change and introduce some flaky tests
> we have fixed in the master. So I think it may be necessary to have a
> discussion before cherry-picking.
>
> The target branches:
>
> - branch-3.0
> - branch-3.1
> - branch-3.2
>
> [0] https://github.com/apache/pulsar/pull/22034
>
> I will keep the discussion open for at least 48 hours.
> If there is no objections, I will perform the cherry-picking.
>
> BR,
> Xiangying
>