You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/21 19:29:15 UTC

[GitHub] [incubator-superset] thunter009 opened a new pull request #8082: add GeoJSON Polygon encoding support to deck.gl Polygon chart

thunter009 opened a new pull request #8082: add GeoJSON Polygon encoding support to deck.gl Polygon chart
URL: https://github.com/apache/incubator-superset/pull/8082
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Currently, the deck.gl Polygon layer only accepts JSON coordinate arrays, polyline, or geohashes as data inputs. This requires user's to perform substantial pre-processing on their data if their data source stores geometry objects as GeoJSON. 
   
   This PR adds GeoJSON encoding support to the deck.gl polygon chart. It will automatically determine if the user supplied polygon data is a GeoJSON (either single or multi-polygon) or a simple JSON coordinate array. All existing charts using JSON coordinate arrays should be unaffected by this change.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   ![image](https://user-images.githubusercontent.com/7088252/63461980-d5212a80-c427-11e9-8978-ac77c8f0f112.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Visual inspection
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org