[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #3172: ARTEMIS-2797 - Allow for removing current queue filter

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #3172:
URL: https://github.com/apache/activemq-artemis/pull/3172#discussion_r438123313



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -689,7 +689,10 @@ public QueueBinding updateQueue(QueueConfiguration queueConfiguration) throws Ex
                queue.setDelayBeforeDispatch(queueConfiguration.getDelayBeforeDispatch().longValue());
             }
             Filter filter = FilterImpl.createFilter(queueConfiguration.getFilterString());
-            if (filter != null && !filter.equals(queue.getFilter())) {
+            if ((filter == null) && (queue.getFilter() != null)) {

Review comment:
       So question here is what is the challenge you have right now? Btw i dont work for a service provider but actually an arch at a financial firm that uses artemis (been using for many yrs), and we manage alot of the broker configuration automatically so be interesting what challenge you have which we havent had to solve.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org