You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/14 02:16:44 UTC
[GitHub] [inlong] lucaspeng12138 opened a new pull request, #6523: [INLONG-6522][Docker] Add notes for building arm images
lucaspeng12138 opened a new pull request, #6523:
URL: https://github.com/apache/inlong/pull/6523
### Prepare a Pull Request
Add notes for building arm images
- Fixes #6522
### Motivation
Add notes for building arm images
### Modifications
Add notes for building arm images
### Verifying this change
Add notes for building arm images
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6523: [INLONG-6522][Docker] Add notes for building arm images
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6523:
URL: https://github.com/apache/inlong/pull/6523#discussion_r1023462361
##########
docker/build-docker-images.sh:
##########
@@ -143,6 +146,11 @@ if [ "$BUILD_ARCH" = "$ARCH_X86" ]; then
docker ${USE_BUILDX} build ${USE_PLATFORM} ${TYPE} -t inlong/tubemq-build:${tag} inlong-tubemq/tubemq-docker/tubemq-build/
fi
+echo "=== Build images result ======="
+docker images | grep inlong
+
Review Comment:
Do we need to add "End to build" info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6523: [INLONG-6522][Docker] Add notes for building arm images
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6523:
URL: https://github.com/apache/inlong/pull/6523#discussion_r1023462361
##########
docker/build-docker-images.sh:
##########
@@ -143,6 +146,11 @@ if [ "$BUILD_ARCH" = "$ARCH_X86" ]; then
docker ${USE_BUILDX} build ${USE_PLATFORM} ${TYPE} -t inlong/tubemq-build:${tag} inlong-tubemq/tubemq-docker/tubemq-build/
fi
+echo "=== Build images result ======="
+docker images | grep inlong
+
Review Comment:
Do we need to add "End to build" info?
I see you add the "End to tag" after the tag result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #6523: [INLONG-6522][Docker] Add notes for building arm images
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #6523:
URL: https://github.com/apache/inlong/pull/6523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org