You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/13 16:57:41 UTC
[jira] [Commented] (TINKERPOP-1668) RepeatUnrollStrategy should not
execute if there is a LoopStep used.
[ https://issues.apache.org/jira/browse/TINKERPOP-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967878#comment-15967878 ]
ASF GitHub Bot commented on TINKERPOP-1668:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/601
TINKERPOP-1668: RepeatUnrollStrategy should not execute if there is a LoopStep used.
https://issues.apache.org/jira/browse/TINKERPOP-1668
If the child traversal of `RepeatStep` has a `LoopsStep`, then `RepeatUnrollStrategy` should not be allowed as it the loops will have been linearized and thus, never incremented. Added test case to verify expected working behavior.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1668
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/601.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #601
----
commit e033e3c6f8132d0b461a75e479ceea8f8b4b9ca8
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-04-13T16:54:29Z
Fixed a bug in where should invalidate the strategy's application.
commit 710bcdba20b65ad33aa4af4b0792cabae9c9e1c8
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-04-13T16:56:54Z
got rid of unneeded imports.
----
> RepeatUnrollStrategy should not execute if there is a LoopStep used.
> --------------------------------------------------------------------
>
> Key: TINKERPOP-1668
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1668
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.2.4
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
>
> BAD.
> {code}
> gremlin> g.V(0L).repeat(groupCount('m').by(loops()).out()).times(31).cap('m')
> ==>[0:31]
> {code}
> GOOD
> {code}
> gremlin> g.V(0L).repeat(groupCount('m').by(loops()).out()).until(loops().is(31)).cap('m')
> ==>[0:1,1:1,2:1,3:1,4:1,5:1,6:1,7:1,8:1,9:1,10:1,11:1,12:1,13:1,14:1,15:1,16:1,17:1,18:1,19:1,20:1,21:1,22:1,23:1,24:1,25:1,26:1,27:1,28:1,29:1,30:1]
> g
> {code}
> If {{LoopStep}} is used, make sure {{RepeatUnrollStrategy}} doesn't execute as the loops are linearized.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)