You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/17 20:39:24 UTC
[GitHub] [iceberg] wypoon opened a new pull request #4155: Core: Remove unused methods in TableMetadata
wypoon opened a new pull request #4155:
URL: https://github.com/apache/iceberg/pull/4155
#4089 in master made some methods in `TableMetadata` unnecessary and removed them.
#4135 fixed a regression in 0.13.x by porting part of #4089. The unused methods in `TableMetadata` should have been removed. We remove them in this follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #4155: Core: Remove unused method accidentally added to TableMetadata
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #4155:
URL: https://github.com/apache/iceberg/pull/4155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] wypoon commented on pull request #4155: Core: Remove unused method accidentally added to TableMetadata
Posted by GitBox <gi...@apache.org>.
wypoon commented on pull request #4155:
URL: https://github.com/apache/iceberg/pull/4155#issuecomment-1043483645
> I don't think this should remove `addStagedSnapshot` or `replaceCurrentSnapshot(Snapshot)` because 0.13.1 is a patch release. It's okay to remove them in master, but I wouldn't do it here. Instead, I'd say we should only remove the method that was accidentally added.
Restored those methods. Only remove the one added by #4135.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4155: Core: Remove unused method accidentally added to TableMetadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4155:
URL: https://github.com/apache/iceberg/pull/4155#issuecomment-1043496601
Thanks, @wypoon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org