[jira] Commented: (OFBIZ-974) Send mail notification from order when shipment sheduled

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510878 ] 

Jacques Le Roux commented on OFBIZ-974:
---------------------------------------

Nicolas, All,

I really tried to make this works but I surrender. Here are some remarks :

Please (re-)read http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices, and notably http://docs.ofbiz.org/display/OFBADMIN/Coding+Conventions
Then don't forgot to put "{}" around while and for blocks and such. Also I find strange to put blanks after "(" and before ")".
Please use last ASL2 headers, there is a convenient HEADERS file in OFBiz root fot that...

Also I wonder if you have really tested this patch
A <ProductStoreEmailSetting is missing in DemoProduct.xml I created this one 
<ProductStoreEmailSetting productStoreId="9000" emailType="PRDS_SHIP_SCHEDULE" bodyScreenLocation="component://order/widget/ordermgr/EmailOrderScreens.xml#ShipmentScheduleNotice" subject="OFBiz Demo - Scheduled Notification for Shipment ${shipment.shipmentId}" bccAddress="ofbiztest@yahoo.com" fromAddress="ofbiztest@yahoo.com"/>

Your  java replacing service sendShipmentScheduledNotification (there is already a simple-method service of the same name) implements  service="orderNotificationInterface"  but I'm not sure it should (I got a missing orderId parameters with it)
In orderItemShipGroup.bsh there is a "*" at end of  line 28

When I correct this I get another problem in line 42 because  orderItemShipGroup is null. This is the case with my use case.  And I'm not quite sure I use  the right use case.
sendShipmentScheduledNotification is trigerred by ECAs in secas_shipment.xml : createShipment and updateShipment which both depend of SHIPMENT_SCHEDULED status. This status is not reached when you Qhick Ship an order or when you use the "Pack Shipment For Ship Group" button in order view. So to reach it I created a  	
"New Shipment For Ship Group" and set the status to scheduled.

Note that I also tried with the existing sendShipmentScheduledNotification simple-method service. The 1st time I got a pb becausr I forgot to put a from party. After that I got also a pb in the sendGenericNotificationEmail because not email body seems available :
java.lang.Exception: Service Error [sendGenericNotificationEmail]: Invalid email body; null is not allowed

Please let me know if I'm missing something...

BTW is anybody really using this service ?

> Send mail notification from order when shipment sheduled
> --------------------------------------------------------
>
>                 Key: OFBIZ-974
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-974
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ecommerce
>    Affects Versions: SVN trunk
>         Environment:  - 
>            Reporter: nicolas malin
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: orderItemShipGroup.tar.bz2, shipmentScheduled-ofbiz.patch
>
>
> In ofbiz when a shipment scheduled, the actual service send email notification directly by information pass to service.
> I extend (and replace) actual service to use productStore email system. When a shipment scheduled, all orders associate to it send an notification email for informe customer how many product quantity send.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.