[jira] [Commented] (HBASE-18439) Subclasses of o.a.h.h.chaos.actions.Action all use the same logger

["Rabi Kumar K C (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921263#comment-16921263 ] 

Rabi Kumar K C commented on HBASE-18439:
----------------------------------------

Hi [~mdrob] If this is not done yet and still needs to be finished can I take this up?? I am planning to create logger for each sub class of Action and create a private LoggerFactory.getLogger(<class_name>.class) and remove static present in Logger of Action class.

> Subclasses of o.a.h.h.chaos.actions.Action all use the same logger
> ------------------------------------------------------------------
>
>                 Key: HBASE-18439
>                 URL: https://issues.apache.org/jira/browse/HBASE-18439
>             Project: HBase
>          Issue Type: Bug
>          Components: integration tests
>            Reporter: Mike Drob
>            Assignee: Jui-Yu Hsieh
>            Priority: Minor
>              Labels: beginner
>
> A bunch of the actions all use the same logger inherited from the super class. We should have them declare distinct loggers, either each one in class or perhaps we can do something dynamically like {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the static modifier on the log field.
> I'm not sure that exact incantation would actually work, but the MethodHandles approach in general is how logger resolution happens in Solr and it actually works out pretty well.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)