You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "nightblure (via GitHub)" <gi...@apache.org> on 2023/02/05 19:53:58 UTC
[GitHub] [superset] nightblure opened a new pull request, #22995: refactor: rename digest param to cache_key in chart API (screenshot m…
nightblure opened a new pull request, #22995:
URL: https://github.com/apache/superset/pull/22995
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
The ```screenshot``` method in the ```charts API``` has the ```digest``` parameter as one of its parameters. This parameter should be called ```cache_key``` because a screenshot is retrieved from the cache using the cache key within the method. The name ```digest``` can be misleading (you might think it could be the ```digest``` property of the Slice object).
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nightblure closed pull request #22995: refactor: rename digest param to cache_key in chart API (screenshot m…
Posted by "nightblure (via GitHub)" <gi...@apache.org>.
nightblure closed pull request #22995: refactor: rename digest param to cache_key in chart API (screenshot m…
URL: https://github.com/apache/superset/pull/22995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org