You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/01/12 10:23:29 UTC

[GitHub] [james-project] Arsnael opened a new pull request #840: JAMES-3680 oidc docker-compose: SLO part

Arsnael opened a new pull request #840:
URL: https://github.com/apache/james-project/pull/840


   WIP
   
   Todo:
   * extract correctly the token value in the payload
   * decode the token and extract the sid claim
   * add the sid to the bloomfilter
   * README changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] chibenwa commented on a change in pull request #840: JAMES-3680 oidc docker-compose: SLO part

Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #840:
URL: https://github.com/apache/james-project/pull/840#discussion_r783818525



##########
File path: examples/oidc/docker-compose.yml
##########
@@ -56,5 +56,15 @@ services:
     image: devopsfaith/krakend:latest
     ports:
       - "8090:8090"
+      - "1234:1234"

Review comment:
       Idem this port should likely not be bount

##########
File path: examples/oidc/docker-compose.yml
##########
@@ -56,5 +56,15 @@ services:
     image: devopsfaith/krakend:latest
     ports:
       - "8090:8090"
+      - "1234:1234"
     volumes:
       - ./krakend/krakend.json:/etc/krakend/krakend.json
+
+  jwt-revoker:
+    depends_on:
+      - krakend
+    container_name: jwt-revoker
+    build:
+      context: ./jwt-revoker
+    ports:
+      - "9000:8080"

Review comment:
       Correct me if I'm wrong: we should not expose this port to the outside. Please do not bind it...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] Arsnael commented on pull request #840: JAMES-3680 oidc docker-compose: SLO part

Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #840:
URL: https://github.com/apache/james-project/pull/840#issuecomment-1011986679


   I still miss the README update


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org


[GitHub] [james-project] Arsnael merged pull request #840: JAMES-3680 oidc docker-compose: SLO part

Posted by GitBox <gi...@apache.org>.
Arsnael merged pull request #840:
URL: https://github.com/apache/james-project/pull/840


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org