Re: Review Request 29324: API call used by Install Wizard to retry installation does not work

[John Speidel <js...@hortonworks.com>]

> On Dec. 22, 2014, 10:24 p.m., Tom Beerbower wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java, line 603
> > <https://reviews.apache.org/r/29324/diff/1/?file=798888#file798888line603>
> >
> >     Any idea why the predicate was being evaluated here?  I just wonder if it was part of some performance optimization that we may be undoing.  I'm fine with removing it if you have tested it.
> 
> Dmitro Lisnichenko wrote:
>     Generally it looks ok to test predicate here but in fact we have inconsistency with state/desiredstate when state in predicate means desiredState in queryResource.

This evaluation was required to ensure that we didn't create stages for host components that don't satisfy the predicate.  An example of this is client components.
After this was removed, the new add hosts api is broken.
I will add this back and fix this issue in another way.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29324/#review65829
-----------------------------------------------------------


On Dec. 22, 2014, 9:17 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29324/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2014, 9:17 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Nate Cole.
> 
> 
> Bugs: AMBARI-8868
>     https://issues.apache.org/jira/browse/AMBARI-8868
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PUT /api/v1/clusters/y1/host_components?HostRoles/state=INSTALLED
> Form Data:
> {"RequestInfo":{"context":"Install Components","operation_level":{"level":"CLUSTER","cluster_name":"y1"}},"Body":{"HostRoles":
> {"state":"INSTALLED"}
> }}
> Server response:
> { "status" : 400, "message" : "java.lang.IllegalArgumentException: Invalid arguments, cluster name, component name and host name should be provided" }
> I saw another failure pattern where the same call returns 500.
> Please try testing this scenario end to end with the UI.
> You can just do a single node install and force invoke failure by renaming /var/lib/ambari-agent dir, for example.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 47d3f70 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 0ffc6e1 
> 
> Diff: https://reviews.apache.org/r/29324/diff/
> 
> 
> Testing
> -------
> 
> in progress
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>