You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "eirikbakke (via GitHub)" <gi...@apache.org> on 2025/02/12 20:28:24 UTC
[PR] Handle both nbres and nbresloc protocols in ImageUtilities.loadImage(URI) [netbeans]
eirikbakke opened a new pull request, #8239:
URL: https://github.com/apache/netbeans/pull/8239
The loadImage(URI) method was added in https://github.com/apache/netbeans/pull/8114 , as part of a broader consolidation of various icon loading methods. After seeing one [log message](https://github.com/apache/netbeans/pull/8235#issuecomment-2654649787), we see that both the `nbres:` and `nbresloc:` protocols should be handled, not just `nbresloc`. The difference is in whether a given file should be loaded with localization suffixes or not, per [this](https://netbeans.apache.org/wiki/main/netbeansdevelopperfaq/DevFaqUriVsUrl/) API documentation.
The log message in question was as follows:
`WARNING [org.openide.util.ImageUtilities]: loadImage(URI) called with unusual URI: nbres:/org/netbeans/modules/form/resources/palette/panel_16.png`
This PR adds handling of the `nbres` case, and changes the handling of the `nbresloc` case to enable loading with localization.
A quick test of the IDE saw no new problems, including in the Matisse form builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Handle both nbres and nbresloc protocols in ImageUtilities.loadImage(URI) [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8239:
URL: https://github.com/apache/netbeans/pull/8239#issuecomment-2655193514
Yeah, I'm just not sure whether ImageUtilities should do anything about it. We could exempt the warning message in case of an "ergoloc" protocol, but then I feel like we should know if it is actually working first...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Handle both nbres and nbresloc protocols in ImageUtilities.loadImage(URI) [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke merged PR #8239:
URL: https://github.com/apache/netbeans/pull/8239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Handle both nbres and nbresloc protocols in ImageUtilities.loadImage(URI) [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8239:
URL: https://github.com/apache/netbeans/pull/8239#issuecomment-2654826772
I did see this similar log warning, but could not immediately figure out what the "ergoloc" protocol was above:
`WARNING [org.openide.util.ImageUtilities]: loadImage(URI) called with unusual URI: ergoloc:/org/netbeans/modules/ide/ergonomics/enterprise/org-netbeans-modules-websvc-core-client-resources-ws_client_16.png`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Handle both nbres and nbresloc protocols in ImageUtilities.loadImage(URI) [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8239:
URL: https://github.com/apache/netbeans/pull/8239#issuecomment-2657298882
Other than ergoloc being a strange device trying to help with back pain I don't know anything about it + it seems to be not used for icons. Lets get this PR in :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Handle both nbres and nbresloc protocols in ImageUtilities.loadImage(URI) [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8239:
URL: https://github.com/apache/netbeans/pull/8239#issuecomment-2654791752
btw good that you added the log warnings in the original PR, otherwise we probably wouldn't have noticed this ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Handle both nbres and nbresloc protocols in ImageUtilities.loadImage(URI) [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8239:
URL: https://github.com/apache/netbeans/pull/8239#issuecomment-2654834502
`ergoloc` sounds ergonomics related. The mechanism which activates clusters when certain wizard entries are hit etc.
https://github.com/search?q=repo%3Aapache%2Fnetbeans%20ergoloc&type=code seems like it isn't used much though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Handle both nbres and nbresloc protocols in ImageUtilities.loadImage(URI) [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8239:
URL: https://github.com/apache/netbeans/pull/8239#issuecomment-2654822735
True! But either way it falls back to the old method that was used to load icons from URLs. It might have missed a localization, or used a bitmap icon instead of an SVG.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Handle both nbres and nbresloc protocols in ImageUtilities.loadImage(URI) [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8239:
URL: https://github.com/apache/netbeans/pull/8239#issuecomment-2657311803
Thanks for reporting the log message!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists