You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xianqing He (Code Review)" <ge...@cloudera.org> on 2021/08/05 06:31:19 UTC

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied 

Xianqing He has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17755


Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................

IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

We should check whether the low and high value of the column on which
the filter is applied is null when printing in TRACE log level.

Testing:
Start impala in TRACE log level and manually test the following
queries:
  1. compute stats functional_parquet.testtbl
  2. select id from testtbl t1 join jointbl t2 on t1.id=t2.test_id

Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
---
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
2 files changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/17755/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 1
Gerrit-Owner: Xianqing He <he...@126.com>

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7386/


-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>
Gerrit-Comment-Date: Wed, 11 Aug 2021 23:52:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................


Patch Set 1: Code-Review+2

Looks great!


-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 1
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>
Gerrit-Comment-Date: Wed, 11 Aug 2021 17:31:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "abeltian (Code Review)" <ge...@cloudera.org>.
abeltian has posted comments on this change. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................


Patch Set 3:

> Uploaded patch set 1.
please write a good, clear commit message, with a short, descriptive title and a message that is exactly long enough to explain what the problem was, and how it was fixed. Each should have 72 or fewer characters if possible.


-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 3
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 03:44:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "guojingfeng (Code Review)" <ge...@cloudera.org>.
guojingfeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................


Patch Set 1: Code-Review+1

Great, we encountered the same problem in my internal 4.x version. The fix solution is almost the same. In my opinion, if we reduce the use of plus operator of String literial will be better.


-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 1
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>
Gerrit-Comment-Date: Wed, 11 Aug 2021 09:04:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9244/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 1
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Aug 2021 06:53:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7386/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>
Gerrit-Comment-Date: Wed, 11 Aug 2021 17:32:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 2
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>
Gerrit-Comment-Date: Wed, 11 Aug 2021 17:32:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 4
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>
Gerrit-Comment-Date: Thu, 26 Aug 2021 19:12:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 4
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 22:44:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7415/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 4
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>
Gerrit-Comment-Date: Tue, 24 Aug 2021 16:24:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17755 )

Change subject: IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied
......................................................................

IMPALA-10843: fix NullPointerException when print the low and high value of the column on which the filter is applied

We should check whether the low and high value of the column on which
the filter is applied is null when printing in TRACE log level.

Testing:
Start impala in TRACE log level and manually test the following
queries:
  1. compute stats functional_parquet.testtbl
  2. select id from testtbl t1 join jointbl t2 on t1.id=t2.test_id

Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Reviewed-on: http://gerrit.cloudera.org:8080/17755
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Qifan Chen <qc...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
2 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Qifan Chen: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/17755
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I653e479adf09f32ec9a6583fd0fe05bc06d2fe2f
Gerrit-Change-Number: 17755
Gerrit-PatchSet: 5
Gerrit-Owner: Xianqing He <he...@126.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: abeltian <ab...@tencent.com>
Gerrit-Reviewer: guojingfeng <gu...@tencent.com>