[lucene-solr] branch jira/LUCENE-9312 updated: Add a TODO in render javadoc

[dw...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dweiss pushed a commit to branch jira/LUCENE-9312
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/jira/LUCENE-9312 by this push:
     new 43c42b7  Add a TODO in render javadoc
43c42b7 is described below

commit 43c42b786d0106d4a6d685e3f396e3da8c81ed49
Author: Dawid Weiss <dw...@apache.org>
AuthorDate: Mon Jul 20 12:09:29 2020 +0200

    Add a TODO in render javadoc
---
 gradle/documentation/render-javadoc.gradle | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gradle/documentation/render-javadoc.gradle b/gradle/documentation/render-javadoc.gradle
index 7fcee58..39f0ad8 100644
--- a/gradle/documentation/render-javadoc.gradle
+++ b/gradle/documentation/render-javadoc.gradle
@@ -165,6 +165,10 @@ class RenderJavadocTask extends DefaultTask {
 
   @TaskAction
   public void render() {
+    // TODO: add 'String executable' property, much like Gradle's built-in javadoc.
+    // resolve lazily to the current JVM's javadoc executable (using the public new API).
+    // the runtime-jvm-support.gradle should then lazily modify this
+    // property if alt jvm is requested (the logic to set alt jvm should be there, not here).
     def javadocCmd = org.gradle.internal.jvm.Jvm.current().getJavadocExecutable()
 
     def srcDirs = srcDirSet.srcDirs.findAll { dir -> dir.exists() }