[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4228: Support Browser protocol at OAP

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r368288209
 
 

 ##########
 File path: oap-server/server-bootstrap/src/main/resources/official_analysis.oal
 ##########
 @@ -102,3 +102,77 @@ envoy_parent_connections_used = from(EnvoyInstanceMetric.value).filter(metricNam
 // disable(top_n_database_statement);
 // disable(zipkin_span);
 // disable(jaeger_span);
+
+
+// Browser metrics begin
 
 Review comment:
   >  In @arugal prev PR, this part of OAL is separated in another OAL
   
   Which PR? I'd like to have a look;
   
   Modularizing the OAL sounds good to me, maybe divide them as per entity or metrics, and make it possible for the users to put their custom metrics in a separate file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services