You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/24 01:18:56 UTC

[GitHub] [arrow-datafusion] andygrove commented on a change in pull request #402: Benchmark subcommand to distinguish between DataFusion and Ballista

andygrove commented on a change in pull request #402:
URL: https://github.com/apache/arrow-datafusion/pull/402#discussion_r637633596



##########
File path: benchmarks/src/bin/tpch.rs
##########
@@ -100,6 +96,45 @@ struct BenchmarkOpt {
     port: Option<u16>,
 }
 
+#[derive(Debug, StructOpt, Clone)]
+struct DatafusionBenchmarkOpt {

Review comment:
       nit: Can we make this `DataFusionBenchmarkOpt`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org