You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "celinayk (via GitHub)" <gi...@apache.org> on 2026/07/13 13:56:31 UTC
[PR] [ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J log… [zeppelin]
celinayk opened a new pull request, #5298:
URL: https://github.com/apache/zeppelin/pull/5298
### What is this PR for?
`BigQueryInterpreter.pollJob(...)` printed job polling status directly to standard output via `System.out.println(...)`, bypassing Zeppelin's SLF4J/Log4j2 logging
configuration, log levels, and appenders. This made diagnostics noisy and hard to route in server/interpreter deployments. This PR replaces the direct stdout call with a
structured SLF4J logger call.
### What type of PR is it?
Improvement
### Todos
* [x] Replace `System.out.println(...)` in `pollJob(...)` with `LOGGER.info(...)`
* [x] Preserve job state and wait interval information in the log message
* [x] No behavior changes to polling, sleeping, or returned job handling
### What is the Jira issue?
[ZEPPELIN-6496](https://issues.apache.org/jira/browse/ZEPPELIN-6496)
### How should this be tested?
* `rg -n "System\.out\.println|System\.err\.println" bigquery/src/main/java/org/apache/zeppelin/bigquery` returns no results
* `./mvnw test -pl bigquery` compiles/builds successfully
* Manually trigger a BigQuery job poll and confirm the state/interval now appears via the configured logger instead of raw stdout
### Screenshots (if appropriate)
N/A
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J logging [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul merged PR #5298:
URL: https://github.com/apache/zeppelin/pull/5298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J logging [zeppelin]
Posted by "celinayk (via GitHub)" <gi...@apache.org>.
celinayk commented on PR #5298:
URL: https://github.com/apache/zeppelin/pull/5298#issuecomment-4964733839
Thanks for the reviews! Updated the PR title to the full form as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6496] Replace BigQuery polling stdout output with SLF4J logging [zeppelin]
Posted by "jongyoul (via GitHub)" <gi...@apache.org>.
jongyoul commented on PR #5298:
URL: https://github.com/apache/zeppelin/pull/5298#issuecomment-4964905200
Merged into master (8b0bf9c3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org