[GitHub] [fineract] Anh3h commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1

[GitBox <gi...@apache.org>]

Anh3h commented on a change in pull request #525: FINERACT-700: upgrade Gradle from 2.10 to 5.2.1
URL: https://github.com/apache/fineract/pull/525#discussion_r266105822
 
 

 ##########
 File path: fineract-provider/build.gradle
 ##########
 @@ -364,7 +363,7 @@ task integrationTest(type:Test){
         tomcatRunWar.daemon = true
         tomcatRunWar.execute()
 
 Review comment:
   > @michaelbukachi I spoke with @muarachmann over the phone and he's trying to update .sql files to be compliant with mysql 8. I'm not really clear as to how upgrading gradle to 5.2.1 will require a mysql upgrade. I understand that the drizzle plugin is not compatible, but shouldn't we just be replacing it with a compatible plugin that still maintains the current mysql syntax?
   > 
   > > Updating of the sql files to support latest mysql/mariadb versions. Note. This can be quite tedious due to the fact there are around 360+ .sql files to go through.
   > 
   > I feel the above should have been in a separate issue IMO.
   
   I think he said he didn't find a compatible drizzle-jdbc plugin. But @muarachmann can still try to do some research on getting a compatible drizzle plugin

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services