[GitHub] [pulsar] coderzc commented on a diff in pull request #19086: [fix][broker] Reject create non existent persistent partitions.

[GitBox <gi...@apache.org>]

coderzc commented on code in PR #19086:
URL: https://github.com/apache/pulsar/pull/19086#discussion_r1059302975


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopicTest.java:
##########
@@ -96,4 +102,21 @@ public void testAccumulativeStats() throws Exception {
         assertEquals(statsAfterUnsubscribe.getBytesOutCounter(), statsBeforeUnsubscribe.getBytesOutCounter());
         assertEquals(statsAfterUnsubscribe.getMsgOutCounter(), statsBeforeUnsubscribe.getMsgOutCounter());
     }
+
+    @Test
+    public void testCreateNonExistentPartitions() throws PulsarAdminException, PulsarClientException {
+        final String topicName = "non-persistent://prop/ns-abc/testCreateNonExistentPartitions";

Review Comment:
   It seems namespace `prop/ns-abc` has not been created yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org