You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "jackshirazi (via GitHub)" <gi...@apache.org> on 2023/04/28 11:34:19 UTC

[GitHub] [tomcat] jackshirazi opened a new pull request, #613: transferTo can transfer only part of the file, so need to loop

jackshirazi opened a new pull request, #613:
URL: https://github.com/apache/tomcat/pull/613

   We (Elastic APM) have a customer (using tomcat 9.0.72) that is hitting this bug. The file copy is getting interrupted (likely from CPU time slicing signals, which is happening because of additional profiling executing in the background) and so only partly completes. As the current implementation doesn't loop, this results in a corrupt war/zip file that can't be loaded. To complete the file copy, transferTo needs to loop


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [GitHub] [tomcat] ChristopherSchultz commented on pull request #613: transferTo can transfer only part of the file, so need to loop

Posted by koteswara Rao Gundapaneni <ko...@gmail.com>.
Just a simple whether the code is useful or not

Regards
Koti

On Tue, 2 May 2023, 07:02 Chuck Caldarale, <n8...@gmail.com> wrote:

>
> On 2023-05-01, at 20:13, koteswara Rao Gundapaneni <
> koti.gundapaneni@gmail.com> wrote:
>
> I have given it for tomcat 7 on long back could you please taken it as
> applicable since no matter of choice that the planet is available whether
> it
>
>
>
> Not sure exactly what you’re asking, but the last Tomcat 7 release was
> over two years ago, and support for Tomcat 7 ended on 31 March 2021.
>
> Apache Tomcat® - End of life for Apache Tomcat 7.0.x
> <https://tomcat.apache.org/tomcat-70-eol.html>
> tomcat.apache.org <https://tomcat.apache.org/tomcat-70-eol.html>
> [image: favicon.ico] <https://tomcat.apache.org/tomcat-70-eol.html>
> <https://tomcat.apache.org/tomcat-70-eol.html>
>
> If you are still using Tomcat 7, you should upgrade to 9.0.x (or at least
> 8.5.x) as soon as possible for security updates and other bug fixes.
>
>   - Chuck
>
>

Re: [GitHub] [tomcat] ChristopherSchultz commented on pull request #613: transferTo can transfer only part of the file, so need to loop

Posted by Chuck Caldarale <n8...@gmail.com>.
> On 2023-05-01, at 20:13, koteswara Rao Gundapaneni <ko...@gmail.com> wrote:
> 
> I have given it for tomcat 7 on long back could you please taken it as
> applicable since no matter of choice that the planet is available whether
> it


Not sure exactly what you’re asking, but the last Tomcat 7 release was over two years ago, and support for Tomcat 7 ended on 31 March 2021. 

https://tomcat.apache.org/tomcat-70-eol.html

If you are still using Tomcat 7, you should upgrade to 9.0.x (or at least 8.5.x) as soon as possible for security updates and other bug fixes.

  - Chuck


Re: [GitHub] [tomcat] ChristopherSchultz commented on pull request #613: transferTo can transfer only part of the file, so need to loop

Posted by koteswara Rao Gundapaneni <ko...@gmail.com>.
I have given it for tomcat 7 on long back could you please taken it as
applicable since no matter of choice that the planet is available whether
it

Regards
Koti

On Mon, 1 May 2023, 22:34 Christopher Schultz, <ch...@christopherschultz.net>
wrote:

> Koti,
>
> On 4/28/23 20:55, koteswara Rao Gundapaneni wrote:
> > May I know whether this request has been taken care by somebody ?
>
> Both the PR comments AND the email posted to the mailing list say that
> the PR has been applied.
>
> -chris
>
> > On Sat, 29 Apr 2023, 03:09 ChristopherSchultz (via GitHub), <
> git@apache.org>
> > wrote:
> >
> >>
> >> ChristopherSchultz commented on PR #613:
> >> URL: https://github.com/apache/tomcat/pull/613#issuecomment-1528121310
> >>
> >>     @rmaucher applied this PR earlier today.
> >>
> >>
> >> --
> >> This is an automated message from the Apache Git Service.
> >> To respond to the message, please log on to GitHub and use the
> >> URL above to go to the specific comment.
> >>
> >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >>
> >> For queries about this service, please contact Infrastructure at:
> >> users@infra.apache.org
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> >> For additional commands, e-mail: dev-help@tomcat.apache.org
> >>
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

Re: [GitHub] [tomcat] ChristopherSchultz commented on pull request #613: transferTo can transfer only part of the file, so need to loop

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Koti,

On 4/28/23 20:55, koteswara Rao Gundapaneni wrote:
> May I know whether this request has been taken care by somebody ?

Both the PR comments AND the email posted to the mailing list say that 
the PR has been applied.

-chris

> On Sat, 29 Apr 2023, 03:09 ChristopherSchultz (via GitHub), <gi...@apache.org>
> wrote:
> 
>>
>> ChristopherSchultz commented on PR #613:
>> URL: https://github.com/apache/tomcat/pull/613#issuecomment-1528121310
>>
>>     @rmaucher applied this PR earlier today.
>>
>>
>> --
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [GitHub] [tomcat] ChristopherSchultz commented on pull request #613: transferTo can transfer only part of the file, so need to loop

Posted by koteswara Rao Gundapaneni <ko...@gmail.com>.
May I know whether this request has been taken care by somebody ?


Regards
Koti

On Sat, 29 Apr 2023, 03:09 ChristopherSchultz (via GitHub), <gi...@apache.org>
wrote:

>
> ChristopherSchultz commented on PR #613:
> URL: https://github.com/apache/tomcat/pull/613#issuecomment-1528121310
>
>    @rmaucher applied this PR earlier today.
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

[GitHub] [tomcat] ChristopherSchultz closed pull request #613: transferTo can transfer only part of the file, so need to loop

Posted by "ChristopherSchultz (via GitHub)" <gi...@apache.org>.
ChristopherSchultz closed pull request #613: transferTo can transfer only part of the file, so need to loop
URL: https://github.com/apache/tomcat/pull/613


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] ChristopherSchultz commented on pull request #613: transferTo can transfer only part of the file, so need to loop

Posted by "ChristopherSchultz (via GitHub)" <gi...@apache.org>.
ChristopherSchultz commented on PR #613:
URL: https://github.com/apache/tomcat/pull/613#issuecomment-1528119740

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] ChristopherSchultz commented on pull request #613: transferTo can transfer only part of the file, so need to loop

Posted by "ChristopherSchultz (via GitHub)" <gi...@apache.org>.
ChristopherSchultz commented on PR #613:
URL: https://github.com/apache/tomcat/pull/613#issuecomment-1528121310

   @rmaucher applied this PR earlier today.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org