You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2025/02/06 20:42:50 UTC
[PR] Update LICENSE/NOTICE in flink-runtime jar files [iceberg]
jbonofre opened a new pull request, #12188:
URL: https://github.com/apache/iceberg/pull/12188
This PR:
- remove airlift slice from `LICENSE` (I don't see it in any flink-runtime jar)
- add Codahale Metrics (present in all flink-runtime jars)
- I check flink-runtime 1.18 and 1.19 and the `LICENSE` and `NOTICE` from 1.20 also apply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update LICENSE/NOTICE in flink-runtime jar files [iceberg]
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #12188:
URL: https://github.com/apache/iceberg/pull/12188#discussion_r1945416902
##########
flink/v1.20/flink-runtime/LICENSE:
##########
@@ -267,14 +267,6 @@ License: http://www.apache.org/licenses/LICENSE-2.0
--------------------------------------------------------------------------------
-This binary artifact contains Airlift Slice.
-
-Copyright: 2013-2020 Slice authors.
-Home page: https://github.com/airlift/slice
-License: http://www.apache.org/licenses/LICENSE-2.0
-
---------------------------------------------------------------------------------
Review Comment:
I think removing Airlift Slice from our License is good, it's not in our JAR (which makes sense since Slice was removed as a dependency from Aircompressor a while back https://github.com/airlift/aircompressor/pull/100) .
##########
flink/v1.20/flink-runtime/LICENSE:
##########
@@ -469,6 +461,14 @@ License: https://www.apache.org/licenses/LICENSE-2.0.html
--------------------------------------------------------------------------------
+This binary artifact contains Codehale Metrics.
+
+Copyright: (c) 2010-2013 Coda Hale, Yammer.com, 2014-2021 Dropwizard Team
+Home page: https://github.com/dropwizard/metrics
+License: https://www.apache.org/licenses/LICENSE-2.0.html
+
+--------------------------------------------------------------------------------
+
Review Comment:
I also agree with adding this, we do depend on these metrics `IcebergStreamWriterMetrics` does some sort of resevoir sampling which uses `SlidingWindowReservoir` from this package and i see classes from this dependency in the jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update LICENSE/NOTICE in flink-runtime jar files [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue commented on PR #12188:
URL: https://github.com/apache/iceberg/pull/12188#issuecomment-2641332325
Thanks for double checking the 1.20 changes, @amogh-jahagirdar!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update LICENSE/NOTICE in flink-runtime jar files [iceberg]
Posted by "rdblue (via GitHub)" <gi...@apache.org>.
rdblue merged PR #12188:
URL: https://github.com/apache/iceberg/pull/12188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org