You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Ankur Goyal <as...@indiana.edu> on 2012/01/11 23:58:16 UTC
Review Request: Review Request for jira ticket: Rave-421: New accounts need
to optionally collect additional information for the Person class,
such as display name, first and last name, etc.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3465/
-----------------------------------------------------------
Review request for rave and Marlon Pierce.
Summary
-------
Added optional text fields for the new user to fill in.
Diffs
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/NewUser.java 1230272
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultNewAccountService.java 1230272
trunk/rave-portal-resources/src/main/resources/messages.properties 1230272
trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1230272
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp 1230272
Diff: https://reviews.apache.org/r/3465/diff
Testing
-------
Thanks,
Ankur
Re: Review Request: Review Request for jira ticket: Rave-421: New accounts
need to optionally collect additional information for the Person class,
such as display name, first and last name, etc.
Posted by Marlon Pierce <mp...@cs.indiana.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3465/#review4473
-----------------------------------------------------------
Ship it!
Looks good.
- Marlon
On 2012-01-11 22:58:16, Ankur Goyal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3465/
> -----------------------------------------------------------
>
> (Updated 2012-01-11 22:58:16)
>
>
> Review request for rave and Marlon Pierce.
>
>
> Summary
> -------
>
> Added optional text fields for the new user to fill in.
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/model/NewUser.java 1230272
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/service/impl/DefaultNewAccountService.java 1230272
> trunk/rave-portal-resources/src/main/resources/messages.properties 1230272
> trunk/rave-portal-resources/src/main/resources/messages_nl.properties 1230272
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/newaccount.jsp 1230272
>
> Diff: https://reviews.apache.org/r/3465/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ankur
>
>