You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Aditya Auradkar <aa...@linkedin.com.INVALID> on 2015/03/13 17:54:04 UTC
[VOTE] KIP-16: Replica Lag Tuning
Details in the KIP, Jira and RB.
https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
https://issues.apache.org/jira/browse/KAFKA-1546
https://reviews.apache.org/r/31967/
Aditya
RE: [VOTE] KIP-16: Replica Lag Tuning
Posted by Aditya Auradkar <aa...@linkedin.com.INVALID>.
Rather, 6 binding +1's.
Aditya
________________________________________
From: Aditya Auradkar
Sent: Sunday, March 15, 2015 10:39 PM
To: dev@kafka.apache.org
Subject: RE: [VOTE] KIP-16: Replica Lag Tuning
Thanks. We have 5 binding +1s. I'll update the KIP with your comments and mark as accepted.
Aditya
________________________________________
From: Jun Rao [jun@confluent.io]
Sent: Sunday, March 15, 2015 8:41 PM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-16: Replica Lag Tuning
+1 on the approach. Much better than before.
Thanks,
Jun
On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar <
aauradkar@linkedin.com.invalid> wrote:
> Details in the KIP, Jira and RB.
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
> https://issues.apache.org/jira/browse/KAFKA-1546
> https://reviews.apache.org/r/31967/
>
> Aditya
>
>
RE: [VOTE] KIP-16: Replica Lag Tuning
Posted by Aditya Auradkar <aa...@linkedin.com.INVALID>.
Thanks. We have 5 binding +1s. I'll update the KIP with your comments and mark as accepted.
Aditya
________________________________________
From: Jun Rao [jun@confluent.io]
Sent: Sunday, March 15, 2015 8:41 PM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-16: Replica Lag Tuning
+1 on the approach. Much better than before.
Thanks,
Jun
On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar <
aauradkar@linkedin.com.invalid> wrote:
> Details in the KIP, Jira and RB.
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
> https://issues.apache.org/jira/browse/KAFKA-1546
> https://reviews.apache.org/r/31967/
>
> Aditya
>
>
Re: [VOTE] KIP-16: Replica Lag Tuning
Posted by Jun Rao <ju...@confluent.io>.
+1 on the approach. Much better than before.
Thanks,
Jun
On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar <
aauradkar@linkedin.com.invalid> wrote:
> Details in the KIP, Jira and RB.
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
> https://issues.apache.org/jira/browse/KAFKA-1546
> https://reviews.apache.org/r/31967/
>
> Aditya
>
>
Re: [VOTE] KIP-16: Replica Lag Tuning
Posted by Joel Koshy <jj...@gmail.com>.
+1 on the KIP
On Fri, Mar 13, 2015 at 04:54:04PM +0000, Aditya Auradkar wrote:
> Details in the KIP, Jira and RB.
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
> https://issues.apache.org/jira/browse/KAFKA-1546
> https://reviews.apache.org/r/31967/
>
> Aditya
>
Re: [VOTE] KIP-16: Replica Lag Tuning
Posted by Guozhang Wang <wa...@gmail.com>.
+1 on the KIP.
On Sun, Mar 15, 2015 at 2:56 PM, Joe Stein <jo...@stealth.ly> wrote:
> +1
>
> one more minor nit, please update the KIP with the link to the discuss
> thread too.
>
> ~ Joe Stein
> - - - - - - - - - - - - - - - - -
>
> http://www.stealth.ly
> - - - - - - - - - - - - - - - - -
>
> On Sun, Mar 15, 2015 at 5:27 PM, Neha Narkhede <ne...@confluent.io> wrote:
>
> > +1 on the KIP. Minor nit: "it is deemed to not be in ISR because it is
> not
> > caught up" => "it is deemed to not be in the ISR because it has fallen
> > behind for more than a certain amount of time as controlled by this
> config"
> >
> > Also took a look at the patch. Looks correct, left review comments.
> Thanks
> > for sharing the test results. This change is going to be great for users!
> >
> > On Sat, Mar 14, 2015 at 9:01 AM, Jay Kreps <ja...@gmail.com> wrote:
> >
> > > +1
> > >
> > > -Jay
> > >
> > > On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar <
> > > aauradkar@linkedin.com.invalid> wrote:
> > >
> > > > Details in the KIP, Jira and RB.
> > > >
> > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
> > > > https://issues.apache.org/jira/browse/KAFKA-1546
> > > > https://reviews.apache.org/r/31967/
> > > >
> > > > Aditya
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > Thanks,
> > Neha
> >
>
--
-- Guozhang
Re: [VOTE] KIP-16: Replica Lag Tuning
Posted by Joe Stein <jo...@stealth.ly>.
+1
one more minor nit, please update the KIP with the link to the discuss
thread too.
~ Joe Stein
- - - - - - - - - - - - - - - - -
http://www.stealth.ly
- - - - - - - - - - - - - - - - -
On Sun, Mar 15, 2015 at 5:27 PM, Neha Narkhede <ne...@confluent.io> wrote:
> +1 on the KIP. Minor nit: "it is deemed to not be in ISR because it is not
> caught up" => "it is deemed to not be in the ISR because it has fallen
> behind for more than a certain amount of time as controlled by this config"
>
> Also took a look at the patch. Looks correct, left review comments. Thanks
> for sharing the test results. This change is going to be great for users!
>
> On Sat, Mar 14, 2015 at 9:01 AM, Jay Kreps <ja...@gmail.com> wrote:
>
> > +1
> >
> > -Jay
> >
> > On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar <
> > aauradkar@linkedin.com.invalid> wrote:
> >
> > > Details in the KIP, Jira and RB.
> > >
> > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
> > > https://issues.apache.org/jira/browse/KAFKA-1546
> > > https://reviews.apache.org/r/31967/
> > >
> > > Aditya
> > >
> > >
> >
>
>
>
> --
> Thanks,
> Neha
>
Re: [VOTE] KIP-16: Replica Lag Tuning
Posted by Neha Narkhede <ne...@confluent.io>.
+1 on the KIP. Minor nit: "it is deemed to not be in ISR because it is not
caught up" => "it is deemed to not be in the ISR because it has fallen
behind for more than a certain amount of time as controlled by this config"
Also took a look at the patch. Looks correct, left review comments. Thanks
for sharing the test results. This change is going to be great for users!
On Sat, Mar 14, 2015 at 9:01 AM, Jay Kreps <ja...@gmail.com> wrote:
> +1
>
> -Jay
>
> On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar <
> aauradkar@linkedin.com.invalid> wrote:
>
> > Details in the KIP, Jira and RB.
> >
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
> > https://issues.apache.org/jira/browse/KAFKA-1546
> > https://reviews.apache.org/r/31967/
> >
> > Aditya
> >
> >
>
--
Thanks,
Neha
Re: [VOTE] KIP-16: Replica Lag Tuning
Posted by Jay Kreps <ja...@gmail.com>.
+1
-Jay
On Fri, Mar 13, 2015 at 9:54 AM, Aditya Auradkar <
aauradkar@linkedin.com.invalid> wrote:
> Details in the KIP, Jira and RB.
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP+16+:+Automated+Replica+Lag+Tuning
> https://issues.apache.org/jira/browse/KAFKA-1546
> https://reviews.apache.org/r/31967/
>
> Aditya
>
>