[jira] [Commented] (HADOOP-18194) Public dataset class for S3A integration tests

["Daniel Carl Jones (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17531249#comment-17531249 ] 

Daniel Carl Jones commented on HADOOP-18194:
--------------------------------------------

I've introduced a simple PublicDatasetTestUtils class in this PR: [https://github.com/apache/hadoop/pull/4140]

Some things that are in this ticket but not in that PR:
 * Hadoop XML config for public data set utils only
 * Skip based on AWS partition (S3A is currently unaware of partition?)
 * Full migration of all public data set dependencies to this new class

> Public dataset class for S3A integration tests
> ----------------------------------------------
>
>                 Key: HADOOP-18194
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18194
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Daniel Carl Jones
>            Assignee: Daniel Carl Jones
>            Priority: Minor
>
> Introduction of PublicDatasetTestUtils as proposed previously in some of the ideas for refactoring S3A incrementally. Some of its responsibilities:
> - Source of truth for getting URI based on public data set.
> - Maybe keep the methods specific to their purpose where possible? We might need {{s3a://landsat-pds/scene_list.gz}} specifically for some tests, but other tests may just need a bucket with a bunch of keys.
> - Introduce test assumptions about the S3 endpoint or AWS partition. If we’re not looking at 'aws' partition, skip test.
> How might we make this generic for non-{{aws}} partition S3 or S3API-compatible object stores?
> - Ideally allow for future extension to provide some easy ways to override the bucket if tester has an alternative source? I see "fs.s3a.scale.test.csvfile" already has a little bit of this.
> - We could have something which takes a path to a hadoop XML config file; we'd have a default resource but the maven build could be pointed at another via a command line property. this file could contain all the settings for a test against a partition or internal s3-compatible store



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org