You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/19 05:22:25 UTC
[GitHub] [spark] obobj opened a new pull request, #37577: [SPARK-40144][WEB UI] Standalone log-view can't load new
obobj opened a new pull request, #37577:
URL: https://github.com/apache/spark/pull/37577
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
log-view.js load new needs to call getBaseURI() of the utils.js file, but does not reference utils.js
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
In Standalone log-view can't load new
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37577: [SPARK-40144][WEB UI] Standalone log-view can't load new
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37577:
URL: https://github.com/apache/spark/pull/37577#issuecomment-1221311837
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #37577: [SPARK-40144][WEB UI] Standalone log-view can't load new
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #37577:
URL: https://github.com/apache/spark/pull/37577#issuecomment-1221777323
@obobj The file utils.js is not in every header.
```
$ find . -name "*.scala"|xargs grep utils.js
./core/src/main/scala/org/apache/spark/ui/exec/ExecutorsTab.scala: <script src={UIUtils.prependBaseUri(request, "/static/utils.js")}></script> ++
./core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala: <script src={UIUtils.prependBaseUri(request, "/static/utils.js")}></script>
./core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala: <script src={UIUtils.prependBaseUri(request, "/static/utils.js")}></script>
```
Could you describe how to reproduce the issue in the PR description? If necessary, we can add the file to the problematic page's header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37577: [SPARK-40144][WEB UI] Standalone log-view can't load new
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37577:
URL: https://github.com/apache/spark/pull/37577#issuecomment-1221733600
cc @gengliangwang @sarutak FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #37577: [SPARK-40144][WEB UI] Standalone log-view can't load new
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #37577:
URL: https://github.com/apache/spark/pull/37577#issuecomment-1335981001
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #37577: [SPARK-40144][WEB UI] Standalone log-view can't load new
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #37577: [SPARK-40144][WEB UI] Standalone log-view can't load new
URL: https://github.com/apache/spark/pull/37577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] obobj commented on pull request #37577: [SPARK-40144][WEB UI] Standalone log-view can't load new
Posted by GitBox <gi...@apache.org>.
obobj commented on PR #37577:
URL: https://github.com/apache/spark/pull/37577#issuecomment-1221969906
> @obobj The file utils.js is not in every header.
>
> ```
> $ find . -name "*.scala"|xargs grep utils.js
> ./core/src/main/scala/org/apache/spark/ui/exec/ExecutorsTab.scala: <script src={UIUtils.prependBaseUri(request, "/static/utils.js")}></script> ++
> ./core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala: <script src={UIUtils.prependBaseUri(request, "/static/utils.js")}></script>
> ./core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala: <script src={UIUtils.prependBaseUri(request, "/static/utils.js")}></script>
> ```
>
> Could you describe how to reproduce the issue in the PR description? If necessary, we can add the file to the problematic page's header.
Chrome Version: 103.0.5060.114
Spark Version：3.2
Clicking the Load New button does not respond, and the console prompts that getBaseURI is not defined
The Load New button corresponds to function loadNew(), loadNew() calls function getRESTEndPoint(), function getRESTEndPoint calls getBaseURI()
<img width="531" alt="image" src="https://user-images.githubusercontent.com/15715341/185865821-2de83b48-b4dc-42cf-9754-e32476f94329.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org