You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2010/03/05 20:16:27 UTC
[jira] Created: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Upgrade maven-bundle-plugin to up to date bnd
---------------------------------------------
Key: FELIX-2176
URL: https://issues.apache.org/jira/browse/FELIX-2176
Project: Felix
Issue Type: Bug
Components: Maven Bundle Plugin
Affects Versions: maven-bundle-plugin-2.0.1
Reporter: David Jencks
Fix For: maven-bundle-plugin-2.1.0
Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
svn rm src/main/java/aQute/lib/osgi/Builder.java
Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924193#action_12924193 ]
Guillaume Nodet commented on FELIX-2176:
----------------------------------------
Is Peter willing to move his efforts on BND to the ASF ?
And I think we'd need a software grant for that, don't we ?
But a big +1 from me if he's willing to do so.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844006#action_12844006 ]
Guillaume Nodet commented on FELIX-2176:
----------------------------------------
The code in PackageVersionAnalyzer compiles if you move the class to aQute.osgi.lib
It adds the bundle version to the private and exported packages if they don't have any version information yet.
The problem is that this happen only when using the manifest goal and not the bundle goal.
This discrepancy looks problematic to me, so I'm tempted to just remove that class and use the same manifest generation.
The version on exported packages can be easily added using:
*;version="${project.version}"
instead of simply
*
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924593#action_12924593 ]
Stuart McCulloch commented on FELIX-2176:
-----------------------------------------
We've included the bnd source code in the past, it's quite straightforward - just put it under src/main/java and comment out the bndlib dependency.
[ btw last I heard Peter was very close to getting the latest bnd sync'd with central, but it's not there yet - so for now I'd go with including the source ]
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860321#action_12860321 ]
David Jencks commented on FELIX-2176:
-------------------------------------
It looks like bndlib v 0.0.397 has made it to maven central. Since no one seemed to like my patch, maybe someone could just update the maven-bundle-plugin to use this publicly available version.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (FELIX-2176) Upgrade
maven-bundle-plugin to up to date bnd
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924638#action_12924638 ]
Richard S. Hall edited comment on FELIX-2176 at 10/25/10 1:55 PM:
------------------------------------------------------------------
Ok, Peter says he's finally figured Maven out, so I will see if I can update to a newer version.
was (Author: rickhall):
Ok, Peter says he's finally figured it out Maven, so I will see if I can update to a newer version.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924685#action_12924685 ]
Richard S. Hall commented on FELIX-2176:
----------------------------------------
Ok, I've updated to the latest bndlib, but I still had an issue. The class PackageVersionAnalyzer access package private super method from Analyzer called analyzeBundelClasspath(). As a result, I had to keep a local copy of Builder and I modified it to expose this method from its super class.
I'm not exactly sure what is going on here. Is this some functionality that we are trying to push into bndlib or what? If so, let's discuss it with Peter so he can get a release out that supports it. Otherwise, we should try to convince Peter to make the method protected so we can access it.
I'm over my head on this one, so please jump in. Thanks.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Peter Kriens (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924890#action_12924890 ]
Peter Kriens commented on FELIX-2176:
-------------------------------------
The function I see is that an Export-Package without a version gets the version of the bundle.
a) The bundle version seems rather arbitrary and cause unnecessary incompatibilities
b) It actually blocks bnd from doing a better job when the package is included from another bundle because at that time there is already a version set
I can add that if there is really no version for an Export-Package to be found (please, please use packageinfo) then I use the bundle version.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844039#action_12844039 ]
Guillaume Nodet commented on FELIX-2176:
----------------------------------------
I've raised FELIX-2194 to handle the differences between manifest / bundle goals.
In the meantime, moving the PackageVersionAnalyzer into the aQute.osgi.lib package should do the trick.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924581#action_12924581 ]
Richard S. Hall commented on FELIX-2176:
----------------------------------------
Seems easier to me to just include the source in our project.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924040#action_12924040 ]
Richard S. Hall commented on FELIX-2176:
----------------------------------------
I'm not against just keeping a copy of the BND code in our repo if it means we can do a better job of keeping BND up-to-date. It seems idiotic to be blocked by the lack of an artifact in a Maven repo.
I had worked with Peter a little while back on heuristics to try to improve how BND decides to import exported packages, since the original behavior was too simplistic and is resulting in the creation of lots of improperly defined bundle metadata. I think updating our plugin to a more recent version of BND is of paramount importance.
Does anyone have any objection to just directly including the BND source in our project?
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843988#action_12843988 ]
Guillaume Nodet commented on FELIX-2176:
----------------------------------------
I'm trying to understand how some commented code affects the generated manifest.
For example the PackageVersionAnalyzer is now commented, so it may affect FELIX-1501, but I can't even reproduce that one.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924410#action_12924410 ]
Richard S. Hall commented on FELIX-2176:
----------------------------------------
I wasn't implying that we try to usurp BND from Peter. I was just suggesting that we include the latest version of the source in the project so we don't have to worry about whether it gets uploaded to Maven or not. It is ASL, so we'd have no issue including the source and we don't want two different artifacts in the first place. We can work on Peter moving BND to Felix later. ;-)
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924978#action_12924978 ]
Richard S. Hall commented on FELIX-2176:
----------------------------------------
I think I agree that it is not clear using the bundle version as the default package version makes sense. However, I'm not against having that as an option if someone wants it. However, we should probably do it like Peter suggests and somehow do it after the fact so bnd can attempt to figure things out first.
So, can we rollback the PackageVersionAnalyzer class and figure out a different way to handle this requirement? If so, then I can eliminate the patched Builder class and we close this issue.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924674#action_12924674 ]
Stuart McCulloch commented on FELIX-2176:
-----------------------------------------
Looks like it's reached central:
http://repo1.maven.org/maven2/biz/aQute/bndlib/1.10.0/
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927009#action_12927009 ]
Richard S. Hall commented on FELIX-2176:
----------------------------------------
I'm still not sure what to do here. Even if we all agree we should add a default version, PackageVersionAnalyzer also removes "META-INF.*" packages from the exported packages apparently...not sure why bnd is including these.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard S. Hall resolved FELIX-2176.
------------------------------------
Resolution: Fixed
Fix Version/s: (was: maven-bundle-plugin-2.1.0)
maven-bundle-plugin-2.2.0
Assignee: Richard S. Hall
I just removed the stuff that I didn't know what to do with and we can address it in other issues.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Assignee: Richard S. Hall
> Fix For: maven-bundle-plugin-2.2.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924586#action_12924586 ]
Guillaume Nodet commented on FELIX-2176:
----------------------------------------
Not from a maintenance point of view imho, unless you forbid any change to the sources, but if you're happy maintaining it, i have no real problems anyway.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843996#action_12843996 ]
Stuart McCulloch commented on FELIX-2176:
-----------------------------------------
This patch should definitely not be applied as it stands for the following reasons:
1) Maven best practices strongly discourage defining external repositories in POMs, as this *will* affect all users of the plugin
2) PackageVersionAnalyzer is needed by Carlos' bundleall goal - perhaps people don't use this goal, but removing this will break any that do
3) The patch changes the parent POM relativePath to an incorrect value (../pom.xml which is the reactor POM, instead of ../pom/pom.xml)
Note that the copy of BND source is meant to be there during development to allow us to test patches on top of the latest BND source
without encountering 1). When it comes to preparing a release I usually negotiate to get the latest BND onto central, and then remove
the source from the release.
Peter is sorting out a regular update process to get BND onto central (via oss.sonatype.org) - once it's there I can make the necessary
updates to PackageVersionAnalyzer, etc. and remove our copy of the BND source code. Until then please don't commit these changes.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924215#action_12924215 ]
David Jencks commented on FELIX-2176:
-------------------------------------
I don't think we need Peter do move BND development to apache to do this. BND is asl licensed and as long as we have appropriate notices in svn and released artifacts we should be able to copy source code into asf svn. Geronimo did this for years with bouncy castle code.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Stuart McCulloch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844009#action_12844009 ]
Stuart McCulloch commented on FELIX-2176:
-----------------------------------------
Except that would break the current contract/behavior of the bundleall goal as mentioned above.
There are other reasons why certain code is different between the manifest and bundle goals,
which is mainly because the bundle goal participates in the maven lifecycle and the manifest
goal doesn't - this means we lack certain runtime data when running the manifest goal.
I'm not against fixing this, but I'd prefer a more reasoned approach than "remove it and see" :)
Really what we need is a series of tests for the bundle and manifest goals, which would make
it easier to change things without unexpectedly breaking anyone. Any chance you could add
some tests for this area first?
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924894#action_12924894 ]
Felix Meschberger commented on FELIX-2176:
------------------------------------------
I tend to agree with Peter that adding a default Export-Package is not a very good idea.
It is probably only acceptable idea for bundles exporting anything. But for bundles which contain some exports and some private packages, the bundle version will increase on each release for modified private packages and then increasing the export version automatically just sounds a bad idea.
So I would argue to not do it (and not even in the interest of being pragmatism), because it IMHO will generate more pain than relieve.
For example: In our commercial application we currently don't use much Export-Package versioning (yes, this is another issue we have to solve). Having automatic export versions will completely prevent us from properly updating bundles.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924446#action_12924446 ]
Guillaume Nodet commented on FELIX-2176:
----------------------------------------
Can't we just use our own maven repo if the goal is only to host the binary file ? We've done that for years for ServiceMix.
It's a lot less work, as bnd isn't even buildable with maven afaik, so the whole release process won't work anyway.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks updated FELIX-2176:
--------------------------------
Attachment: FELIX-2176.diff
Use up to date bnd, include it in plugin, and make everything compile. tests pass but it's possible the removed code actually did something useful although not tested.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924777#action_12924777 ]
Guillaume Nodet commented on FELIX-2176:
----------------------------------------
Yeah, IIRC, the idea was to push that back into bnd, but i never had the time to actually submit a patch to Peter ...
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924453#action_12924453 ]
David Jencks commented on FELIX-2176:
-------------------------------------
its easy to build the bnd code with maven, you just get it in an appropriate structure. IIRC my original patch showed how to do this, possibly automatically. private maven repos are really not appropriate for public projects in my experience.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924638#action_12924638 ]
Richard S. Hall commented on FELIX-2176:
----------------------------------------
Ok, Peter says he's finally figured it out Maven, so I will see if I can update to a newer version.
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to
date bnd
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924217#action_12924217 ]
Guillaume Nodet commented on FELIX-2176:
----------------------------------------
So what's the point of having software grant and ICLAs then and the whole IP stuff ?
I trust you on that, I just seem to be hermetic to the whole thing ....
> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
> Key: FELIX-2176
> URL: https://issues.apache.org/jira/browse/FELIX-2176
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.1
> Reporter: David Jencks
> Fix For: maven-bundle-plugin-2.1.0
>
> Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo. The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd. I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it. You'll need to run
> svn rm src/main/java/aQute/lib/osgi/Builder.java
> Also the code in src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd. However I can't actually tell what its trying to do; I commented it out. If this functionality is actually in bnd then removing the class would be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.