You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by momomatteo <gi...@git.apache.org> on 2017/04/21 11:06:06 UTC
[GitHub] cordova-plugin-media-capture pull request #76: Audio Capture - added support...
GitHub user momomatteo opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/76
Audio Capture - added support for iPhone 6 and iPhone 6 Plus microphone images
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Added microphone images for iPhone 6 and iPhone 6 Plus screen sizes
### What testing has been done on this change?
Tested on iPhone 6 and iPhone 6 Plus
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/momomatteo/cordova-plugin-media-capture master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit 21ae965237f339b92e4b163ba8042be3abcd56cf
Author: Matteo Momo <ma...@gmail.com>
Date: 2017-04-21T09:19:14Z
Added temporary images for iPhone6 and iPhone6 Plus devices
commit 76d13f7b19be2a32b1c56a450f2d451e9e11f813
Author: Matteo Momo <ma...@gmail.com>
Date: 2017-04-21T10:02:35Z
Removed temporary unused images ad reduced iPhone6 image
commit 67a12e12094c7c9ea0d3ab8fd8af848827aa888c
Author: Matteo Momo <ma...@gmail.com>
Date: 2017-04-21T10:11:09Z
Reduced iPhone6 image size
commit 8dca285726649164718d233bf71c7ab3b6bf65b6
Author: Matteo Momo <ma...@gmail.com>
Date: 2017-04-21T10:28:49Z
Reduced iPhone6 Plus image size
commit 9e42b48ce05271af9d0ed8ec3f22433a0a536fbe
Author: Matteo Momo <ma...@gmail.com>
Date: 2017-04-21T10:52:39Z
Replaced test images with real microphone images
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
It is always nice to have, but not specifically required; sending a pr is proof of the intent to contribute.
In this case the graphics are really just resized versions of existing files, so this is a modification.
If brand new images were generated then we might need to insist as the ICLA also protects us from someone contributing something they don't have the rights to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Posted by jaredloson <gi...@git.apache.org>.
Github user jaredloson commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
@filmaj Got it, thanks for the info!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
@jaredloson there is some kind of GitHub issue that is causing havoc with read-only mirrors right now. Apache Infra + GitHub are actively working on it.
If you need to access the source, you can always do so via git.apache.org/cordova-plugin-media-capture.git.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
they are both device specific, and cordova specific
I see these as something that an app developer should be providing themselves, unfortunately there is not an API for this, or a demo/doc of how a developer would do it.
The images already exist for every other device shape and size, so this isn't a new thing, just covering more new devices.
That said, I have never really agreed with the direction of providing a generic UI inside this plugin, ...
But, It is probably better to just accept this pr, and move on with another implementation some day when we find the time.
The fact that @momomatteo ;) has taken the time to send this pr should speak much louder than my personal feelings on the subject ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
Ping @purplecabbage @shazron for a quick review. Is having these microphone images something we would want?
I am concerned that the images and configuration for this addition seem very device-specific.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
Cordova CI Build has completed successfully.
**Commit** - [Link](https://github.com/apache/cordova-plugin-media-capture/pull/76/commits/9e42b48ce05271af9d0ed8ec3f22433a0a536fbe)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture-pr/36/)
72 tests run, 0 skipped, 0 failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
@momomatteo can you put the issue id (CB-12562) on the title so it's linked with the original issue on JIRA?
Also, can you remove one of the `#import <Cordova/CDVAvailability.h>`? you duplicated it
And finally, after those changes, can you squash all the commits into one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Posted by jaredloson <gi...@git.apache.org>.
Github user jaredloson commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
Leaving this here because I can't find any info elsewhere. Does anyone know why this repo is suddenly empty?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
Do we need an ICLA signed for this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org