You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "HsbcJone (via GitHub)" <gi...@apache.org> on 2023/05/01 15:17:57 UTC
[GitHub] [incubator-seatunnel] HsbcJone opened a new pull request, #4698: [Feature][Connector][Http] Support multi-line text splits #4649
HsbcJone opened a new pull request, #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
https://github.com/apache/incubator-seatunnel/issues/4649
## Purpose of this pull request
[Feature][Connector][Http] Support multi-line text splits
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [x] Code changed are covered with tests, or it does not need tests for reason:
* [x] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HsbcJone commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "HsbcJone (via GitHub)" <gi...@apache.org>.
HsbcJone commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1535656322
I have added **e2e testing classes** and optimized the code style . @hailin0 @TyrantLucifer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HsbcJone commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "HsbcJone (via GitHub)" <gi...@apache.org>.
HsbcJone commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1534848107
> > add e2e testcase into this case
> > https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/src/test/java/org/apache/seatunnel/e2e/connector/http/HttpIT.java#L91
>
> +1
get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HsbcJone commented on a diff in pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "HsbcJone (via GitHub)" <gi...@apache.org>.
HsbcJone commented on code in PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#discussion_r1185704190
##########
docs/en/connector-v2/source/Github.md:
##########
@@ -17,22 +17,23 @@ Used to read data from Github.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| access_token | String | No | - |
-| method | String | No | get |
-| schema.fields | Config | No | - |
-| format | String | No | json |
-| params | Map | No | - |
-| body | String | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | config | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| access_token | String | No | - |
+| method | String | No | get |
+| schema.fields | Config | No | - |
+| format | String | No | json |
+| params | Map | No | - |
+| body | String | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | config | No | - |
+| enable_multi_lines | boolean | No | false |
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HsbcJone commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "HsbcJone (via GitHub)" <gi...@apache.org>.
HsbcJone commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1535655242
> check ci error
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1534186664
> add e2e testcase into this case
>
> https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/src/test/java/org/apache/seatunnel/e2e/connector/http/HttpIT.java#L91
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1535721709
<img width="552" alt="image" src="https://user-images.githubusercontent.com/14371345/236384523-dfa60fdf-017f-4485-924a-e392d7fcf306.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HsbcJone commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits #4649
Posted by "HsbcJone (via GitHub)" <gi...@apache.org>.
HsbcJone commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1529832283
The code has been submitted and local testing has passed. We hope you can review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HsbcJone commented on a diff in pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "HsbcJone (via GitHub)" <gi...@apache.org>.
HsbcJone commented on code in PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#discussion_r1185680934
##########
docs/en/connector-v2/source/Github.md:
##########
@@ -17,22 +17,23 @@ Used to read data from Github.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| access_token | String | No | - |
-| method | String | No | get |
-| schema.fields | Config | No | - |
-| format | String | No | json |
-| params | Map | No | - |
-| body | String | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | config | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| access_token | String | No | - |
+| method | String | No | get |
+| schema.fields | Config | No | - |
+| format | String | No | json |
+| params | Map | No | - |
+| body | String | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | config | No | - |
+| enableMultiLines | boolean | No | false |
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HsbcJone commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "HsbcJone (via GitHub)" <gi...@apache.org>.
HsbcJone commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1535751221
> <img alt="image" width="552" src="https://user-images.githubusercontent.com/14371345/236384523-dfa60fdf-017f-4485-924a-e392d7fcf306.png">
Fixed this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] davidzollo merged pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HsbcJone commented on a diff in pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "HsbcJone (via GitHub)" <gi...@apache.org>.
HsbcJone commented on code in PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#discussion_r1185073734
##########
docs/en/connector-v2/source/Http.md:
##########
@@ -17,23 +17,24 @@ Used to read data from Http.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| schema | Config | No | - |
-| schema.fields | Config | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| format | String | No | json |
-| method | String | No | get |
-| headers | Map | No | - |
-| params | Map | No | - |
-| body | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| schema | Config | No | - |
+| schema.fields | Config | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| format | String | No | json |
+| method | String | No | get |
+| headers | Map | No | - |
+| params | Map | No | - |
+| body | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | | No | - |
+| enableMultiLines | boolean | No | false |
Review Comment:
> Is this setting required for connectors other than http?
Yes, I think this configuration is universal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] HsbcJone commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "HsbcJone (via GitHub)" <gi...@apache.org>.
HsbcJone commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1535805212
> > <img alt="image" width="552" src="https://user-images.githubusercontent.com/14371345/236384523-dfa60fdf-017f-4485-924a-e392d7fcf306.png">
>
> Fixed this issue
CI-All checks have passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1535623311
check ci error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#discussion_r1185677197
##########
docs/en/connector-v2/source/Github.md:
##########
@@ -17,22 +17,23 @@ Used to read data from Github.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| access_token | String | No | - |
-| method | String | No | get |
-| schema.fields | Config | No | - |
-| format | String | No | json |
-| params | Map | No | - |
-| body | String | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | config | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| access_token | String | No | - |
+| method | String | No | get |
+| schema.fields | Config | No | - |
+| format | String | No | json |
+| params | Map | No | - |
+| body | String | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | config | No | - |
+| enableMultiLines | boolean | No | false |
Review Comment:
```suggestion
| enable_multi_lines | boolean | No | false |
| common-options | config | No | - |
```
##########
docs/en/connector-v2/source/Github.md:
##########
@@ -17,22 +17,23 @@ Used to read data from Github.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| access_token | String | No | - |
-| method | String | No | get |
-| schema.fields | Config | No | - |
-| format | String | No | json |
-| params | Map | No | - |
-| body | String | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | config | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| access_token | String | No | - |
+| method | String | No | get |
+| schema.fields | Config | No | - |
+| format | String | No | json |
+| params | Map | No | - |
+| body | String | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | config | No | - |
+| enableMultiLines | boolean | No | false |
Review Comment:
Update all this configuration item name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4698: [Feature][Connector][Http] Support multi-line text splits #4649
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#discussion_r1184473318
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java:
##########
@@ -130,6 +132,24 @@ public void pollNext(Collector<SeaTunnelRow> output) throws Exception {
}
}
+ /**
+ * deal lineData
+ *
+ * @param output
+ * @param data
+ * @throws IOException
+ */
+ private void dealLineData(Collector<SeaTunnelRow> output, String data) throws IOException {
Review Comment:
```suggestion
private void collect(Collector<SeaTunnelRow> output, String data) throws IOException {
```
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpConfig.java:
##########
@@ -83,6 +84,13 @@ public class HttpConfig {
.withDescription(
"SeaTunnel content field.This parameter can get some json data, and there is no need to configure each field separately.");
+ public static final Option<Boolean> ENABLEMULTILINES =
Review Comment:
```suggestion
public static final Option<Boolean> ENABLE_MULTI_LINES =
```
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java:
##########
@@ -130,6 +132,24 @@ public void pollNext(Collector<SeaTunnelRow> output) throws Exception {
}
}
+ /**
+ * deal lineData
+ *
+ * @param output
+ * @param data
+ * @throws IOException
+ */
Review Comment:
```suggestion
```
##########
docs/en/connector-v2/source/Http.md:
##########
@@ -17,23 +17,24 @@ Used to read data from Http.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| schema | Config | No | - |
-| schema.fields | Config | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| format | String | No | json |
-| method | String | No | get |
-| headers | Map | No | - |
-| params | Map | No | - |
-| body | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| schema | Config | No | - |
+| schema.fields | Config | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| format | String | No | json |
+| method | String | No | get |
+| headers | Map | No | - |
+| params | Map | No | - |
+| body | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | | No | - |
+| enableMultiLines | boolean | No | false |
Review Comment:
Is this setting required for connectors other than http?
##########
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/config/HttpConfig.java:
##########
@@ -83,6 +84,13 @@ public class HttpConfig {
.withDescription(
"SeaTunnel content field.This parameter can get some json data, and there is no need to configure each field separately.");
+ public static final Option<Boolean> ENABLEMULTILINES =
+ Options.key("enableMultiLines")
Review Comment:
```suggestion
Options.key("enable_multi_lines")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits #4649
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1533984537
add e2e testcase into this case
https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/src/test/java/org/apache/seatunnel/e2e/connector/http/HttpIT.java#L91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#discussion_r1185682436
##########
docs/en/connector-v2/source/Github.md:
##########
@@ -17,22 +17,23 @@ Used to read data from Github.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| access_token | String | No | - |
-| method | String | No | get |
-| schema.fields | Config | No | - |
-| format | String | No | json |
-| params | Map | No | - |
-| body | String | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | config | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| access_token | String | No | - |
+| method | String | No | get |
+| schema.fields | Config | No | - |
+| format | String | No | json |
+| params | Map | No | - |
+| body | String | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | config | No | - |
+| enable_multi_lines | boolean | No | false |
Review Comment:
update all this config item
##########
docs/en/connector-v2/source/Github.md:
##########
@@ -17,22 +17,23 @@ Used to read data from Github.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| access_token | String | No | - |
-| method | String | No | get |
-| schema.fields | Config | No | - |
-| format | String | No | json |
-| params | Map | No | - |
-| body | String | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | config | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| access_token | String | No | - |
+| method | String | No | get |
+| schema.fields | Config | No | - |
+| format | String | No | json |
+| params | Map | No | - |
+| body | String | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | config | No | - |
+| enable_multi_lines | boolean | No | false |
Review Comment:
move to the front of `common-options`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#discussion_r1185677616
##########
docs/en/connector-v2/source/Github.md:
##########
@@ -17,22 +17,23 @@ Used to read data from Github.
## Options
-| name | type | required | default value |
-|-----------------------------|--------|----------|---------------|
-| url | String | Yes | - |
-| access_token | String | No | - |
-| method | String | No | get |
-| schema.fields | Config | No | - |
-| format | String | No | json |
-| params | Map | No | - |
-| body | String | No | - |
-| json_field | Config | No | - |
-| content_json | String | No | - |
-| poll_interval_ms | int | No | - |
-| retry | int | No | - |
-| retry_backoff_multiplier_ms | int | No | 100 |
-| retry_backoff_max_ms | int | No | 10000 |
-| common-options | config | No | - |
+| name | type | required | default value |
+|-----------------------------|---------|----------|---------------|
+| url | String | Yes | - |
+| access_token | String | No | - |
+| method | String | No | get |
+| schema.fields | Config | No | - |
+| format | String | No | json |
+| params | Map | No | - |
+| body | String | No | - |
+| json_field | Config | No | - |
+| content_json | String | No | - |
+| poll_interval_ms | int | No | - |
+| retry | int | No | - |
+| retry_backoff_multiplier_ms | int | No | 100 |
+| retry_backoff_max_ms | int | No | 10000 |
+| common-options | config | No | - |
+| enableMultiLines | boolean | No | false |
Review Comment:
Update all this configuration item name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4698: [Feature][Connector][Http] Support multi-line text splits
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4698:
URL: https://github.com/apache/incubator-seatunnel/pull/4698#issuecomment-1535664615
check ci error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org