You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by steveloughran <gi...@git.apache.org> on 2015/11/22 19:37:47 UTC
[GitHub] hadoop pull request: HDFS-9263
GitHub user steveloughran opened a pull request:
https://github.com/apache/hadoop/pull/53
HDFS-9263
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveloughran/hadoop jenkins/HDFS-9263_build_test_data
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hadoop/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit a2a7df4f521602fef3bd49c708b0fecb080c50a1
Author: Steve Loughran <st...@hortonworks.com>
Date: 2015-10-19T14:06:08Z
HDFS-9263: set up GTU for single place for test dir/path setup
commit c2391515fc2eed5fa1249020585cccd94a6b523d
Author: Steve Loughran <st...@hortonworks.com>
Date: 2015-10-19T14:07:19Z
HDFS-9263 factoring out refs to build test propertyes & paths in hadoop-common
commit 646811a57765532c6b2be701b67a964435b1ed50
Author: Steve Loughran <st...@hortonworks.com>
Date: 2015-10-19T14:07:37Z
HDFS-9263 hdft-tests
commit cac0e86d6fa51ae97df9995ddea3f0df3ad6601d
Author: Steve Loughran <st...@hortonworks.com>
Date: 2015-10-19T19:03:35Z
HDFS-9263 mapreduce tests
commit ce93191dbf3e6d631736561d795573369286de88
Author: Steve Loughran <st...@hortonworks.com>
Date: 2015-10-19T19:03:53Z
HDFS-9263 hadoop archive test
commit 6eb8f0ecb9e220779740e263cdcd68b23ef9e681
Author: Steve Loughran <st...@hortonworks.com>
Date: 2015-11-22T18:34:40Z
HDFS-9263 MiniDFS cluster to use hardcoded subdir under test dir.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] hadoop pull request: HDFS-9263
Posted by cnauroth <gi...@git.apache.org>.
Github user cnauroth commented on a diff in the pull request:
https://github.com/apache/hadoop/pull/53#discussion_r45787996
--- Diff: hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/GenericTestUtils.java ---
@@ -59,6 +59,22 @@
private static final AtomicInteger sequence = new AtomicInteger();
+ /**
+ * system property for test data: {@value}
+ */
+ public static final String SYSPROP_TEST_DATA_DIR = "test.build.data";
+
+ /**
+ * Default path for test data: {@value}
+ */
+ public static final String DEFAULT_TEST_DATA_DIR =
+ "target " + File.pathSeparator + "test" + File.pathSeparator + "data";
--- End diff --
I think you'll still need to incorporate the fixes I suggested earlier in a JIRA comment: remove the extra space character at the end of the `"target "` string literal, and switch from `File.pathSeparator` to `File.separator`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---