You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by "Michael Scheetz (JIRA)" <ji...@apache.org> on 2009/09/24 23:02:16 UTC
[jira] Created: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
SearchEngine.listModules returns MRID without extra attributes.
---------------------------------------------------------------
Key: IVY-1128
URL: https://issues.apache.org/jira/browse/IVY-1128
Project: Ivy
Issue Type: Bug
Components: Core
Affects Versions: 2.1.0-RC2
Environment: Ivy 2.1.0-rc2 - 20090704004254
Apache Ant version 1.7.0 compiled on December 13 2006
Reporter: Michael Scheetz
The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Michael Scheetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Scheetz updated IVY-1128:
---------------------------------
Attachment: IVY-1128b.improvetest.patch
Added more to the repository
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Assignee: Maarten Coene
> Fix For: trunk
>
> Attachments: IVY-1128.fix.svn.patch, IVY-1128b.improvetest.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Michael Scheetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Scheetz updated IVY-1128:
---------------------------------
Attachment: IVY-1128.fix.svn.patch
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Attachments: IVY-1128.fix.svn.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene updated IVY-1128:
-------------------------------
Fix Version/s: 2.2.0-RC1
(was: trunk)
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Assignee: Maarten Coene
> Fix For: 2.2.0-RC1
>
> Attachments: IVY-1128.fix.svn.patch, IVY-1128b.improvetest.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene resolved IVY-1128.
--------------------------------
Resolution: Fixed
ok, I did miss some critical part of your original patch, sorry about that.
I've now committed an additional change to SVN trunk which should solve the problem, could you please give it a try.
thanks!
Maarten
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Assignee: Maarten Coene
> Fix For: trunk
>
> Attachments: IVY-1128.fix.svn.patch, IVY-1128b.improvetest.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Michael Scheetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762761#action_12762761 ]
Michael Scheetz commented on IVY-1128:
--------------------------------------
Maarten,
Yes, this change looks like it worked. Thanks for your help to get this patch (and all of the others) into production.
Michael
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Assignee: Maarten Coene
> Fix For: trunk
>
> Attachments: IVY-1128.fix.svn.patch, IVY-1128b.improvetest.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Michael Scheetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Scheetz updated IVY-1128:
---------------------------------
Attachment: IVY-1128.fix.svnpatch
SVN patch file contains a test and fix.
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Attachments: IVY-1128.fix.svnpatch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene resolved IVY-1128.
--------------------------------
Resolution: Fixed
Fix Version/s: trunk
Assignee: Maarten Coene
I've applied a little modified version of your patch into SVN trunk.
Could you give it a try?
Thanks!
Maarten
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Assignee: Maarten Coene
> Fix For: trunk
>
> Attachments: IVY-1128.fix.svn.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Michael Scheetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Scheetz updated IVY-1128:
---------------------------------
Attachment: (was: IVY-1128.fix.svn.patch)
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Attachments: IVY-1128.fix.svn.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Michael Scheetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761419#action_12761419 ]
Michael Scheetz commented on IVY-1128:
--------------------------------------
Maarten,
The list of modules returned by ivy.listModules(criteria, settings.getMatcher(PatternMatcher.REGEXP)) now contain the extra attributes, so that part is fixed.
However, the method does not honor all of the search criteria stated by the ModuleRevisionId. That is, the extra attributes are ignored as search parameters. The returned list contains all of the modules that match the "org,name,revision" portion of the mrid. It should return only the modules which match "org,name,revision,extraAtts".
Michael
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Assignee: Maarten Coene
> Fix For: trunk
>
> Attachments: IVY-1128.fix.svn.patch, IVY-1128b.improvetest.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Michael Scheetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Scheetz reopened IVY-1128:
----------------------------------
The additional entries in the repository are listed as dependencies when they should not be. See the additional patch for repository enhancements.
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Assignee: Maarten Coene
> Fix For: trunk
>
> Attachments: IVY-1128.fix.svn.patch, IVY-1128b.improvetest.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Michael Scheetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Scheetz updated IVY-1128:
---------------------------------
Attachment: (was: IVY-1128.fix.svnpatch)
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Michael Scheetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Scheetz updated IVY-1128:
---------------------------------
Attachment: IVY-1128.fix.svn.patch
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Attachments: IVY-1128.fix.svn.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1128) SearchEngine.listModules returns MRID
without extra attributes.
Posted by "Michael Scheetz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Scheetz updated IVY-1128:
---------------------------------
Comment: was deleted
(was: The additional entries in the repository are listed as dependencies when they should not be. See the additional patch for repository enhancements.)
> SearchEngine.listModules returns MRID without extra attributes.
> ---------------------------------------------------------------
>
> Key: IVY-1128
> URL: https://issues.apache.org/jira/browse/IVY-1128
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.1.0-RC2
> Environment: Ivy 2.1.0-rc2 - 20090704004254
> Apache Ant version 1.7.0 compiled on December 13 2006
> Reporter: Michael Scheetz
> Assignee: Maarten Coene
> Fix For: trunk
>
> Attachments: IVY-1128.fix.svn.patch, IVY-1128b.improvetest.patch
>
>
> The ModuleRevisionId objects that are returned by the SearchEngine.listModules(ModuleRevisionId, PatternMatcher) method does not contain any extra attributes. If extra attributes are passed in then they should also be added to the returned module. Without the extra attributes then then the modules returned are practically useless for any further use. This method is published in the Ivy class, too.
> See attached for test and fix patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.