You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/10 08:39:52 UTC
[GitHub] [incubator-seatunnel] JiangTChen opened a new pull request #994: Use ${project.parent.version} instead of deprecated ${parent.version}
JiangTChen opened a new pull request #994:
URL: https://github.com/apache/incubator-seatunnel/pull/994
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] felix-thinkingdata removed a comment on pull request #994: [Improvement]Use ${project.parent.version} instead of deprecated ${parent.version}
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata removed a comment on pull request #994:
URL: https://github.com/apache/incubator-seatunnel/pull/994#issuecomment-1009561263
> ${parent.version}
Yes, THERE is a version of Maven that says ${parent. Version} is a syntax error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] felix-thinkingdata commented on pull request #994: [Improvement]Use ${project.parent.version} instead of deprecated ${parent.version}
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on pull request #994:
URL: https://github.com/apache/incubator-seatunnel/pull/994#issuecomment-1009561263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #994: [Improvement][example]Use ${project.version} instead of deprecated ${parent.version}
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #994:
URL: https://github.com/apache/incubator-seatunnel/pull/994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #994: [Improvement]Use ${project.parent.version} instead of deprecated ${parent.version}
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #994:
URL: https://github.com/apache/incubator-seatunnel/pull/994#issuecomment-1009520987
hi @JiangTChen, does any document describe `${parent.version}` is deprecated? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] JiangTChen commented on pull request #994: [Improvement]Use ${project.parent.version} instead of deprecated ${parent.version}
Posted by GitBox <gi...@apache.org>.
JiangTChen commented on pull request #994:
URL: https://github.com/apache/incubator-seatunnel/pull/994#issuecomment-1009562609
>
> Hi @JiangTChen, mvn command output this message only `seatunnel-core-flink` module? What about the other modules?
Hi @leo65535 @felix-thinkingdata ,yes! only 'seatunnel-core-flink' has this problem. Other module is ${project.version}.
I pushed again with ${project.version}. please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] JiangTChen edited a comment on pull request #994: [Improvement]Use ${project.parent.version} instead of deprecated ${parent.version}
Posted by GitBox <gi...@apache.org>.
JiangTChen edited a comment on pull request #994:
URL: https://github.com/apache/incubator-seatunnel/pull/994#issuecomment-1009526390
>
> hi @JiangTChen, does any document describe `${parent.version}` is deprecated? thanks.
Hi @leo65535, You can run `mvn clean`, then you will see below warning.
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.apache.seatunnel:seatunnel-flink-examples:jar:2.0.5-SNAPSHOT
[WARNING] The expression ${parent.version} is deprecated. Please use ${project.parent.version} instead.
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] JiangTChen commented on pull request #994: [Improvement]Use ${project.parent.version} instead of deprecated ${parent.version}
Posted by GitBox <gi...@apache.org>.
JiangTChen commented on pull request #994:
URL: https://github.com/apache/incubator-seatunnel/pull/994#issuecomment-1009526390
>
> hi @JiangTChen, does any document describe `${parent.version}` is deprecated? thanks.
Hi Leo, You can run `mvn clean`, then you will see below warning.
[WARNING]
[WARNING] Some problems were encountered while building the effective model for org.apache.seatunnel:seatunnel-flink-examples:jar:2.0.5-SNAPSHOT
[WARNING] The expression ${parent.version} is deprecated. Please use ${project.parent.version} instead.
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #994: [Improvement]Use ${project.parent.version} instead of deprecated ${parent.version}
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #994:
URL: https://github.com/apache/incubator-seatunnel/pull/994#issuecomment-1009559226
Hi @JiangTChen, mvn command output this message only `seatunnel-core-flink` module? What about the other modules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org