You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/19 14:24:35 UTC
[GitHub] [netbeans] svenreimers opened a new pull request #1886: Update to
Groovy 2.5.9 and enable groovy editor tests
svenreimers opened a new pull request #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886
Enables tests for groovy.editor on travis
Fixed NETBEANS-1150
Fixed NETBEANS-3668
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on issue #1886: Update to Groovy
2.5.9 and enable groovy editor tests
Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886#issuecomment-591019437
hi @svenreimers, is the https://issues.apache.org/jira/browse/NETBEANS-1150 fixed now ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on issue #1886: Update to Groovy
2.5.9 and enable groovy editor tests
Posted by GitBox <gi...@apache.org>.
ebarboni commented on issue #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886#issuecomment-576392140
hi, sorry will not merge because of the test and pending discussion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] svenreimers commented on issue #1886: Update to Groovy
2.5.9 and enable groovy editor tests
Posted by GitBox <gi...@apache.org>.
svenreimers commented on issue #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886#issuecomment-576415289
Discussion closed. Fix applied. Test removed. Hoping all will green...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mario-s commented on a change in pull request #1886:
Update to Groovy 2.5.9 and enable groovy editor tests
Posted by GitBox <gi...@apache.org>.
mario-s commented on a change in pull request #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886#discussion_r368564006
##########
File path: groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/completion/inference/TypeInferenceVisitor.java
##########
@@ -194,4 +193,29 @@ private static boolean sameVariableName(ASTNode node1, FieldNode node2) {
&& ((VariableExpression) node1).getName().equals(node2.getName());
}
+ private ClassNode deriveExpressonType(Expression expression) {
Review comment:
What about a single return statement here? IMHO those are too many. It's also a bit inconsistent with the previous method (visitDeclarationExpression).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #1886: Update to Groovy
2.5.9 and enable groovy editor tests
Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] svenreimers commented on issue #1886: Update to Groovy
2.5.9 and enable groovy editor tests
Posted by GitBox <gi...@apache.org>.
svenreimers commented on issue #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886#issuecomment-576055984
There is one small problem with one completion test. Seems to be caused by the upgrade to 2.5.9. Looking into the root cause right now - I am not sure what the correct assumption for the completion is so one possibility to get this PR in is to disable the test because it is related to Grails, which we do not support at the moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] svenreimers edited a comment on issue #1886: Update to
Groovy 2.5.9 and enable groovy editor tests
Posted by GitBox <gi...@apache.org>.
svenreimers edited a comment on issue #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886#issuecomment-576415289
Discussion closed. Fix applied. Test removed. Hoping all will be green soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] svenreimers edited a comment on issue #1886: Update to
Groovy 2.5.9 and enable groovy editor tests
Posted by GitBox <gi...@apache.org>.
svenreimers edited a comment on issue #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886#issuecomment-576415289
Discussion closed. Fix applied. Test removed. Hoping all will be green soon and still makes into 11.3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mario-s commented on a change in pull request #1886:
Update to Groovy 2.5.9 and enable groovy editor tests
Posted by GitBox <gi...@apache.org>.
mario-s commented on a change in pull request #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886#discussion_r368564006
##########
File path: groovy/groovy.editor/src/org/netbeans/modules/groovy/editor/completion/inference/TypeInferenceVisitor.java
##########
@@ -194,4 +193,29 @@ private static boolean sameVariableName(ASTNode node1, FieldNode node2) {
&& ((VariableExpression) node1).getName().equals(node2.getName());
}
+ private ClassNode deriveExpressonType(Expression expression) {
Review comment:
What abbout a single return statement here? IMHO those are too many. It's also a bit inconsistent with the previous method (visitDeclarationExpression).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] svenreimers commented on issue #1886: Update to Groovy
2.5.9 and enable groovy editor tests
Posted by GitBox <gi...@apache.org>.
svenreimers commented on issue #1886: Update to Groovy 2.5.9 and enable groovy editor tests
URL: https://github.com/apache/netbeans/pull/1886#issuecomment-591023139
Yes...Totally forgot about this...Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists