You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/07/21 04:00:13 UTC

[GitHub] [shardingsphere] Swastyy opened a new pull request #11425: Add config change history of ShardingSphere-Proxy

Swastyy opened a new pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425


   Fixes #10990 
   
   Changes proposed in this pull request:
   - Created ShardingSphere-Proxy folder inside API-change-history
   - Updated the `_index.en.md` file
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-884291470


   [Here](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-jdbc/configuration/yaml/change-history/) is an example of ShardingSphere-JDBC.
   
   For `server.yaml`,  we only need to list the differences between several major versions of `server.yaml`. 
   Like 5.0.0, 4.x, 3.x, 2.x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy edited a comment on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
Swastyy edited a comment on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-884287526


   > > > Hi @Swastyy
   > > > Thanks for your hard work!
   > > > I think there may be some misunderstandings. ShargingSphere-Proxy has a configuration file `server.yaml`, which is not exist in `ShardingSphere-JDBC`.
   > > > The configuration in `server.yaml` changes in different versions, so this record of change history is needed.
   > > > For example:
   > > > the structure of authority configuratio has changed by #10297, you can refer to the git history of the file [server.yaml](https://github.com/apache/shardingsphere/blob/master/shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/resources/conf/server.yaml) .
   > I'm sorry I didn't understand what you mean. What we need to do now is to add a change history, so have you read the git history? This file has indeed been updated many times, with new and changed parameters.
   
   Git history is in file itself? I can see it in mentioned pull request above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-887212001


   Hey @tristaZero, @strongduanmu Pl check this PR once.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-883908774


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11425](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d309ae3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/00213e5038f137909de409519f7445d5f7b95fd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00213e5) will **decrease** coverage by `0.22%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11425/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11425      +/-   ##
   ============================================
   - Coverage     63.44%   63.21%   -0.23%     
   - Complexity     1090     1095       +5     
   ============================================
     Files          2220     2227       +7     
     Lines         33836    34072     +236     
     Branches       5900     5937      +37     
   ============================================
   + Hits          21467    21539      +72     
   - Misses        10651    10792     +141     
   - Partials       1718     1741      +23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ql/parser/core/resource/ResourceDistSQLParser.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL3Jlc291cmNlL1Jlc291cmNlRGlzdFNRTFBhcnNlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...core/resource/ResourceDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL3Jlc291cmNlL1Jlc291cmNlRGlzdFNRTFN0YXRlbWVudFZpc2l0b3IuamF2YQ==) | `0.00% <0.00%> (-91.31%)` | :arrow_down: |
   | [...ere/agent/metrics/api/advice/DataSourceAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtcGx1Z2lucy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1wbHVnaW4tbWV0cmljcy9zaGFyZGluZ3NwaGVyZS1hZ2VudC1tZXRyaWNzLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvbWV0cmljcy9hcGkvYWR2aWNlL0RhdGFTb3VyY2VBZHZpY2UuamF2YQ==) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [...ore/resource/ResourceSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9jb3JlL3Jlc291cmNlL1Jlc291cmNlU1FMU3RhdGVtZW50UGFyc2VyRW5naW5lLmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...stsql/parser/api/DistSQLStatementParserEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXIvc2hhcmRpbmdzcGhlcmUtZGlzdHNxbC1wYXJzZXItZW5naW5lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kaXN0c3FsL3BhcnNlci9hcGkvRGlzdFNRTFN0YXRlbWVudFBhcnNlckVuZ2luZS5qYXZh) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [.../apache/shardingsphere/shadow/rule/ShadowRule.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcnVsZS9TaGFkb3dSdWxlLmphdmE=) | `54.54% <0.00%> (-45.46%)` | :arrow_down: |
   | [...initializer/impl/StandardBootstrapInitializer.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9pbml0aWFsaXplci9pbXBsL1N0YW5kYXJkQm9vdHN0cmFwSW5pdGlhbGl6ZXIuamF2YQ==) | `28.57% <0.00%> (-38.10%)` | :arrow_down: |
   | [...rdingsphere/infra/rule/single/SingleTableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9ydWxlL3NpbmdsZS9TaW5nbGVUYWJsZVJ1bGUuamF2YQ==) | `31.25% <0.00%> (-31.25%)` | :arrow_down: |
   | [...esher/type/CreateViewStatementSchemaRefresher.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9zY2hlbWEvcmVmcmVzaGVyL3R5cGUvQ3JlYXRlVmlld1N0YXRlbWVudFNjaGVtYVJlZnJlc2hlci5qYXZh) | `77.77% <0.00%> (-22.23%)` | :arrow_down: |
   | [...itializer/impl/GovernanceBootstrapInitializer.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9pbml0aWFsaXplci9pbXBsL0dvdmVybmFuY2VCb290c3RyYXBJbml0aWFsaXplci5qYXZh) | `58.82% <0.00%> (-19.90%)` | :arrow_down: |
   | ... and [72 more](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00213e5...d309ae3](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-886347712


   @tristaZero Please review it once.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-884274257


   > > Hi @Swastyy
   > > Thanks for your hard work!
   > > I think there may be some misunderstandings. ShargingSphere-Proxy has a configuration file `server.yaml`, which is not exist in `ShardingSphere-JDBC`.
   > > The configuration in `server.yaml` changes in different versions, so this record of change history is needed.
   > > For example:
   > > the structure of authority configuratio has changed by #10297, you can refer to the git history of the file [server.yaml](https://github.com/apache/shardingsphere/blob/master/shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/resources/conf/server.yaml) .
   > 
   > Hey, I have a doubt like changement of authority configuration is not what we want right? We want to store the changes of `server.yaml` so putting the users sections inside the authority in `server.yaml` file is not we will do. I mean we won't make any change in the above file right?
   
   I'm sorry I didn't understand what you mean. What we need to do now is to add a change history, so have you read the git history? This file has indeed been updated many times, with new and changed parameters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-884097028


   Hi @Swastyy 
   Thanks for your hard work!
   I think there may be some misunderstandings. ShargingSphere-Proxy has a configuration file `server.yaml`, which is not exist in `ShardingSphere-JDBC`.
   The configuration in `server.yaml` changes in different versions, so this record of change history is needed.
   For example: 
   the structure of authority configuratio has changed by #10297, you can refer to the git history of the file [server.yaml](https://github.com/apache/shardingsphere/blob/master/shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/resources/conf/server.yaml) .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-884283726


   > `authority` is just a change in server.yaml, we need to record this update so that users know how to modify the configuration when upgrading the version.
   
   How to do that? I mean if there is any example


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-884287526


   > > > Hi @Swastyy
   > > > Thanks for your hard work!
   > > > I think there may be some misunderstandings. ShargingSphere-Proxy has a configuration file `server.yaml`, which is not exist in `ShardingSphere-JDBC`.
   > > > The configuration in `server.yaml` changes in different versions, so this record of change history is needed.
   > > > For example:
   > > > the structure of authority configuratio has changed by #10297, you can refer to the git history of the file [server.yaml](https://github.com/apache/shardingsphere/blob/master/shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/resources/conf/server.yaml) .
   > > 
   > > 
   > > Hey, I have a doubt like changement of authority configuration is not what we want right? We want to store the changes of `server.yaml` so putting the users sections inside the authority in `server.yaml` file is not we will do. I mean we won't make any change in the above file right?
   > 
   > I'm sorry I didn't understand what you mean. What we need to do now is to add a change history, so have you read the git history? This file has indeed been updated many times, with new and changed parameters.
   
   Git history is in file itself?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-887213712


   > Hi @Swastyy thanks for your update, nice job. ;-)
   
   Thank you so much for the instant reply @tristaZero 🎉 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-884075187


   @tristaZero @strongduanmu @RaigorJiang Pl review this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-884267085


   > Hi @Swastyy
   > Thanks for your hard work!
   > I think there may be some misunderstandings. ShargingSphere-Proxy has a configuration file `server.yaml`, which is not exist in `ShardingSphere-JDBC`.
   > The configuration in `server.yaml` changes in different versions, so this record of change history is needed.
   > For example:
   > the structure of authority configuratio has changed by #10297, you can refer to the git history of the file [server.yaml](https://github.com/apache/shardingsphere/blob/master/shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/resources/conf/server.yaml) .
   
   Hey, I have a doubt like changement of authority configuration is not what we want right? We want to store the changes of `server.yaml` so putting the users sections inside the authority in `server.yaml` file is not we will do. I mean we won't make any change in the above file right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-886330517


   @Swastyy 
   Thanks for your efforts.  I think it's OK.
   The earlier version information is more scattered, I can supplement it through subsequent PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-883908774


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11425](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f176ca) into [master](https://codecov.io/gh/apache/shardingsphere/commit/00213e5038f137909de409519f7445d5f7b95fd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00213e5) will **decrease** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11425/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11425      +/-   ##
   ============================================
   - Coverage     63.44%   63.37%   -0.07%     
     Complexity     1090     1090              
   ============================================
     Files          2220     2220              
     Lines         33836    33836              
     Branches       5900     5900              
   ============================================
   - Hits          21467    21445      -22     
   - Misses        10651    10674      +23     
   + Partials       1718     1717       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sphere/scaling/core/job/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2Ivc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=) | `22.22% <0.00%> (-29.63%)` | :arrow_down: |
   | [...re/scaling/core/executor/engine/ExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRvci9lbmdpbmUvRXhlY3V0ZUVuZ2luZS5qYXZh) | `88.88% <0.00%> (-11.12%)` | :arrow_down: |
   | [...scaling/core/job/task/inventory/InventoryTask.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbnZlbnRvcnkvSW52ZW50b3J5VGFzay5qYXZh) | `68.88% <0.00%> (-6.67%)` | :arrow_down: |
   | [...ing/core/job/task/incremental/IncrementalTask.java](https://codecov.io/gh/apache/shardingsphere/pull/11425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbmNyZW1lbnRhbC9JbmNyZW1lbnRhbFRhc2suamF2YQ==) | `72.91% <0.00%> (-2.09%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [00213e5...9f176ca](https://codecov.io/gh/apache/shardingsphere/pull/11425?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-886061149


   @RaigorJiang I could only find about the versions 5.0.0-beta and 4.1.1 in the git history of `server.yaml` file. Please review it again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-884276009


   `authority` is just a change in server.yaml, we need to record this update so that users know how to modify the configuration when upgrading the version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Swastyy commented on pull request #11425: Add config change history of ShardingSphere-Proxy

Posted by GitBox <gi...@apache.org>.
Swastyy commented on pull request #11425:
URL: https://github.com/apache/shardingsphere/pull/11425#issuecomment-884297056


   > > > > Hi @Swastyy
   > > > > Thanks for your hard work!
   > > > > I think there may be some misunderstandings. ShargingSphere-Proxy has a configuration file `server.yaml`, which is not exist in `ShardingSphere-JDBC`.
   > > > > The configuration in `server.yaml` changes in different versions, so this record of change history is needed.
   > > > > For example:
   > > > > the structure of authority configuratio has changed by #10297, you can refer to the git history of the file [server.yaml](https://github.com/apache/shardingsphere/blob/master/shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/main/resources/conf/server.yaml) .
   > > > 
   > > > 
   > > > Hey, I have a doubt like changement of authority configuration is not what we want right? We want to store the changes of `server.yaml` so putting the users sections inside the authority in `server.yaml` file is not we will do. I mean we won't make any change in the above file right?
   > > 
   > > 
   > > I'm sorry I didn't understand what you mean. What we need to do now is to add a change history, so have you read the git history? This file has indeed been updated many times, with new and changed parameters.
   > 
   > Git history is in file itself?
   
   
   
   > [Here](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-jdbc/configuration/yaml/change-history/) is an example of ShardingSphere-JDBC.
   > 
   > For `server.yaml`, we only need to list the differences between several major versions of `server.yaml`.
   > Like 5.0.0, 4.x, 3.x, 2.x.
   
   Ohhk I get it. Thank you so much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org